Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 2750623002: Avoid unnecessary LocalSurfaceId allocation in RenderWidgetHostViewChildFrame/Guest (Closed)
Patch Set: Added test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest.h
diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h
index fea13850ab586babd0e47695985cd93f34ecf83a..e5c20e65a228cb1c249de1e4b173f94afb092a23 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.h
+++ b/content/browser/frame_host/render_widget_host_view_guest.h
@@ -125,12 +125,9 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
bool IsRenderWidgetHostViewGuest() override;
RenderWidgetHostViewBase* GetOwnerRenderWidgetHostView() const;
- protected:
+ private:
friend class RenderWidgetHostView;
- bool ShouldCreateNewSurfaceId(uint32_t compositor_frame_sink_id,
- const cc::CompositorFrame& frame) override;
- private:
void SendSurfaceInfoToEmbedderImpl(
const cc::SurfaceInfo& surface_info,
const cc::SurfaceSequence& sequence) override;
@@ -154,6 +151,8 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
int browser_plugin_instance_id,
const blink::WebInputEvent* event);
+ bool HasEmbedderChanged() override;
+
// BrowserPluginGuest and RenderWidgetHostViewGuest's lifetimes are not tied
// to one another, therefore we access |guest_| through WeakPtr.
base::WeakPtr<BrowserPluginGuest> guest_;

Powered by Google App Engine
This is Rietveld 408576698