Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2750583003: Remove -internals-media-controls-text-track-list* as web exposed CSS selector. (Closed)

Created:
3 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove -internals-media-controls-text-track-list* as web exposed CSS selector. It has been deprecated since M57 and the usage is quite low now. Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ngqnEQg7xac/7YgrxvuXAgAJ BUG=678285 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2750583003 Cr-Commit-Position: refs/heads/master@{#456682} Committed: https://chromium.googlesource.com/chromium/src/+/34cad83d81a686a09b2350ef31fdb1e2279bc770

Patch Set 1 #

Patch Set 2 : remove unrelated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
M third_party/WebKit/LayoutTests/media/deprecated-css-selectors-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
mlamouri (slow - plz ping)
PTAL. FWIW, I will send an email to the thread for an update. TL;DR: YouTube ...
3 years, 9 months ago (2017-03-13 18:16:58 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-13 19:42:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750583003/20001
3 years, 9 months ago (2017-03-14 11:49:30 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 13:19:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34cad83d81a686a09b2350ef31fd...

Powered by Google App Engine
This is Rietveld 408576698