Remove -internals-media-controls-cast-button as web exposed CSS selector.

Remove -internals-media-controls-cast-button as web exposed CSS selector.

It has been deprecated since M57 and the usage is fairly low.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5145TSF3FJM/aAqhKuuXAgAJ

BUG=678285
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2734093003
Cr-Commit-Position: refs/heads/master@{#456524}
Committed: https://chromium.googlesource.com/chromium/src/+/554a52a54cc66abb2e1555180ec87df11c1709ae

[mlamouri (slow - plz ping), 2017-03-07 16:17:35]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 16:18:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:22:30]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mlamouri (slow - plz ping), 2017-03-10 11:35:48]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 11:36:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2017-03-10 11:41:12]

PTAL :)

[jochen (gone - plz use gerrit), 2017-03-10 11:54:33]

can you link to the intent to remove?

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:798:
CSSSelectorInternalMediaControlsCastButton = 1063,
nit. keep for historical reference?

[commit-bot: I haz the power, 2017-03-10 13:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 13:08:51]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-03-13 12:26:56]

Description was changed from

==========
Remove -internals-media-controls-cast-button as web exposed CSS selector.

It has been deprecated since M57 and the usage is fairly low.

BUG=678285
R=jochen@chromium.org
==========

to

==========
Remove -internals-media-controls-cast-button as web exposed CSS selector.

It has been deprecated since M57 and the usage is fairly low.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/5145TSF3FJM/aAqhKuuX...

BUG=678285
R=jochen@chromium.org
==========

[mlamouri (slow - plz ping), 2017-03-13 12:27:07]

PTAL

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:798:
CSSSelectorInternalMediaControlsCastButton = 1063,
On 2017/03/10 at 11:54:33, jochen wrote:
> nit. keep for historical reference?

My understanding is that we do remove them from UseCounter but keep them in
histograms.xml. Do you think we should do something different?

[jochen (gone - plz use gerrit), 2017-03-13 19:41:53]

lgtm either way

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:798:
CSSSelectorInternalMediaControlsCastButton = 1063,
On 2017/03/13 at 12:27:07, mlamouri wrote:
> On 2017/03/10 at 11:54:33, jochen wrote:
> > nit. keep for historical reference?
> 
> My understanding is that we do remove them from UseCounter but keep them in
histograms.xml. Do you think we should do something different?

what's the point of removing this here?

[mlamouri (slow - plz ping), 2017-03-13 21:04:27]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-03-13 21:04:28]

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2734093003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:798:
CSSSelectorInternalMediaControlsCastButton = 1063,
On 2017/03/13 at 19:41:53, jochen wrote:
> On 2017/03/13 at 12:27:07, mlamouri wrote:
> > On 2017/03/10 at 11:54:33, jochen wrote:
> > > nit. keep for historical reference?
> > 
> > My understanding is that we do remove them from UseCounter but keep them in
histograms.xml. Do you think we should do something different?
> 
> what's the point of removing this here?

Avoid dead code I guess. histograms.xml being there for history.

[commit-bot: I haz the power, 2017-03-13 21:05:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 23:05:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489439067927040,
"parent_rev": "2376acd53cf462a35e9330fe298590d02ea084f9", "commit_rev":
"554a52a54cc66abb2e1555180ec87df11c1709ae"}

[commit-bot: I haz the power, 2017-03-13 23:06:10]

Description was changed from

==========
Remove -internals-media-controls-cast-button as web exposed CSS selector.

It has been deprecated since M57 and the usage is fairly low.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/5145TSF3FJM/aAqhKuuX...

BUG=678285
R=jochen@chromium.org
==========

to

==========
Remove -internals-media-controls-cast-button as web exposed CSS selector.

It has been deprecated since M57 and the usage is fairly low.

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/5145TSF3FJM/aAqhKuuX...

BUG=678285
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2734093003
Cr-Commit-Position: refs/heads/master@{#456524}
Committed:
https://chromium.googlesource.com/chromium/src/+/554a52a54cc66abb2e1555180ec8...
==========

[commit-bot: I haz the power, 2017-03-13 23:06:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/554a52a54cc66abb2e1555180ec8...