Headless: Pass devtools request id to the URLFetcher

Headless: Pass devtools request id to the URLFetcher

BUG=546953
Review-Url: https://codereview.chromium.org/2750513002
Cr-Commit-Position: refs/heads/master@{#456377}
Committed: https://chromium.googlesource.com/chromium/src/+/283b4a2162c016bcd28b3766ea3c5e9c932ecfe4

[alex clarke (OOO till 29th), 2017-03-13 11:03:35]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2017-03-13 12:08:25]

lgtm.

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/generi...
File headless/public/util/generic_url_request_job_test.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/generi...
headless/public/util/generic_url_request_job_test.cc:58: const std::string&
devtools_request_id_,
nit: no trailing underscore

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
File headless/public/util/http_url_fetcher.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
headless/public/util/http_url_fetcher.cc:187: const std::string&
devtools_request_id_,
nit: no trailing underscore

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
File headless/public/util/http_url_fetcher.h (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
headless/public/util/http_url_fetcher.h:28: const std::string&
devtools_request_id_,
nit: no trailing underscore

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/protoc...
File headless/public/util/protocol_handler_request_id_browsertest.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/protoc...
headless/public/util/protocol_handler_request_id_browsertest.cc:72: const
std::string& devtools_request_id_,
nit: no trailing underscore

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
File headless/public/util/url_fetcher.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
headless/public/util/url_fetcher.cc:43: const std::string& devtools_request_id_,
nit: no trailing underscore

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
File headless/public/util/url_fetcher.h (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
headless/public/util/url_fetcher.h:66: const std::string& devtools_request_id_,
nit: no trailing underscore

[alex clarke (OOO till 29th), 2017-03-13 13:38:22]

Thanks

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/generi...
File headless/public/util/generic_url_request_job_test.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/generi...
headless/public/util/generic_url_request_job_test.cc:58: const std::string&
devtools_request_id_,
On 2017/03/13 12:08:24, Sami wrote:
> nit: no trailing underscore

Done.

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
File headless/public/util/http_url_fetcher.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
headless/public/util/http_url_fetcher.cc:187: const std::string&
devtools_request_id_,
On 2017/03/13 12:08:24, Sami wrote:
> nit: no trailing underscore

Done.

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
File headless/public/util/http_url_fetcher.h (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/http_u...
headless/public/util/http_url_fetcher.h:28: const std::string&
devtools_request_id_,
On 2017/03/13 12:08:24, Sami wrote:
> nit: no trailing underscore

Done.

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/protoc...
File headless/public/util/protocol_handler_request_id_browsertest.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/protoc...
headless/public/util/protocol_handler_request_id_browsertest.cc:72: const
std::string& devtools_request_id_,
On 2017/03/13 12:08:24, Sami wrote:
> nit: no trailing underscore

Done.

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
File headless/public/util/url_fetcher.cc (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
headless/public/util/url_fetcher.cc:43: const std::string& devtools_request_id_,
On 2017/03/13 12:08:24, Sami wrote:
> nit: no trailing underscore

Done.

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
File headless/public/util/url_fetcher.h (right):

https://codereview.chromium.org/2750513002/diff/1/headless/public/util/url_fe...
headless/public/util/url_fetcher.h:66: const std::string& devtools_request_id_,
On 2017/03/13 12:08:24, Sami wrote:
> nit: no trailing underscore

Done.

[alex clarke (OOO till 29th), 2017-03-13 13:38:30]

The CQ bit was checked by alexclarke@chromium.org

[commit-bot: I haz the power, 2017-03-13 13:38:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-03-13 13:38:54]

The CQ bit was unchecked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-03-13 13:39:49]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-03-13 13:39:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2750513002/#ps20001
(title: "Remove underscores")

[commit-bot: I haz the power, 2017-03-13 13:39:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 14:42:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489412389765110,
"parent_rev": "d25a9b7ba1e9858fe4d444267524f8ebe8ad8594", "commit_rev":
"283b4a2162c016bcd28b3766ea3c5e9c932ecfe4"}

[commit-bot: I haz the power, 2017-03-13 14:42:53]

Description was changed from

==========
Headless: Pass devtools request id to the URLFetcher

BUG=546953
==========

to

==========
Headless: Pass devtools request id to the URLFetcher

BUG=546953

Review-Url: https://codereview.chromium.org/2750513002
Cr-Commit-Position: refs/heads/master@{#456377}
Committed:
https://chromium.googlesource.com/chromium/src/+/283b4a2162c016bcd28b3766ea3c...
==========

[commit-bot: I haz the power, 2017-03-13 14:42:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/283b4a2162c016bcd28b3766ea3c...