Headless: Pass devtools request id to the URLFetcher

headless/public/util/protocol_handler_request_id_browsertest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/test/browser_test.h"
 #include "headless/public/devtools/domains/network.h"
 #include "headless/public/devtools/domains/page.h"
 #include "headless/public/headless_devtools_client.h"
@@ skipping 51 matching lines @@
    public:
     explicit MockURLFetcher(
         const RequestIdCorrelationProtocolHandler* protocol_handler)
         : protocol_handler_(protocol_handler) {}
     ~MockURLFetcher() override {}
 
     // URLFetcher implementation:
     void StartFetch(const GURL& url,
                     const std::string& method,
                     const net::HttpRequestHeaders& request_headers,
+                    const std::string& devtools_request_id_,

[Sami, 2017/03/13 12:08:24]

nit: no trailing underscore

[alex clarke (OOO till 29th), 2017/03/13 13:38:22]

Done.

                     ResultListener* result_listener) override {
       const Response* response = protocol_handler_->GetResponse(url.spec());
       if (!response)
         result_listener->OnFetchStartError(net::ERR_FILE_NOT_FOUND);
 
       // The header used for correlation should not be sent to the fetcher.
       EXPECT_FALSE(request_headers.HasHeader(kDevtoolsRequestId));
 
       result_listener->OnFetchCompleteExtractHeaders(
           url, 200, response->data.c_str(), response->data.size());
@@ skipping 142 matching lines @@
   }
 
  private:
   std::map<std::string, std::string> url_to_devtools_id_;
   RequestIdCorrelationProtocolHandler* http_handler_;  // NOT OWNED
 };
 
 HEADLESS_ASYNC_DEVTOOLED_TEST_F(ProtocolHandlerRequestIdCorrelationTest);
 
 }  // namespace headless