Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2750483007: Only show a beforeunload dialog if a frame has been interacted with. (Closed)

Created:
3 years, 9 months ago by Avi (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only show a beforeunload dialog if a frame has been interacted with. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : new test #

Patch Set 4 : moar #

Patch Set 5 : fix #

Patch Set 6 : user gestures directly #

Patch Set 7 : rev #

Patch Set 8 : android? #

Patch Set 9 : exceptions! #

Patch Set 10 : wait fix #

Patch Set 11 : with test #

Patch Set 12 : rev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -40 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java View 1 2 3 4 5 6 7 8 9 5 chunks +40 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 23 chunks +40 lines, -35 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +36 lines, -0 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 1 2 3 4 5 14 chunks +66 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +38 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/render_frame_host/beforeunload.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/resources/iframe-with-beforeunload.html View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/loader/show-only-one-beforeunload-dialog.html View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resources/reentrant-beforeunload-helper.html View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 49 (49 generated)
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-15 17:33:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/1
3 years, 9 months ago (2017-03-15 17:33:56 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-15 18:28:07 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/384836)
3 years, 9 months ago (2017-03-15 18:28:07 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-17 20:18:04 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/20001
3 years, 9 months ago (2017-03-17 20:18:26 UTC) #6
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-17 20:39:36 UTC) #7
Avi (use Gerrit)
Description was changed from ========== Only show a beforeunload dialog if a frame has been ...
3 years, 9 months ago (2017-03-17 20:39:37 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/40001
3 years, 9 months ago (2017-03-17 20:39:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-17 21:11:16 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/329276)
3 years, 9 months ago (2017-03-17 21:11:17 UTC) #11
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-17 22:46:03 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/60001
3 years, 9 months ago (2017-03-17 22:46:57 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-17 23:13:46 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/252948)
3 years, 9 months ago (2017-03-17 23:13:46 UTC) #15
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-17 23:18:15 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/80001
3 years, 9 months ago (2017-03-17 23:19:28 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-18 00:27:24 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/386354)
3 years, 9 months ago (2017-03-18 00:27:25 UTC) #19
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-18 18:16:30 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/100001
3 years, 9 months ago (2017-03-18 18:16:41 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-18 19:25:02 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/411786)
3 years, 9 months ago (2017-03-18 19:25:03 UTC) #23
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-18 19:46:59 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/120001
3 years, 9 months ago (2017-03-18 19:47:09 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-18 21:22:28 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/253156)
3 years, 9 months ago (2017-03-18 21:22:29 UTC) #27
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-25 00:53:22 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/140001
3 years, 9 months ago (2017-03-25 00:53:59 UTC) #29
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-25 01:14:21 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/160001
3 years, 9 months ago (2017-03-25 01:14:49 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-25 01:54:51 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/391324)
3 years, 9 months ago (2017-03-25 01:54:52 UTC) #33
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-25 19:53:35 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/180001
3 years, 9 months ago (2017-03-25 19:53:49 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-25 21:13:55 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/416695)
3 years, 9 months ago (2017-03-25 21:13:56 UTC) #37
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-26 03:57:18 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/180001
3 years, 9 months ago (2017-03-26 03:57:33 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-26 06:18:57 UTC) #40
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-26 06:18:58 UTC) #41
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-03 19:57:30 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/200001
3 years, 8 months ago (2017-04-03 19:58:20 UTC) #43
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-03 20:38:16 UTC) #44
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isolation/builds/7105)
3 years, 8 months ago (2017-04-03 20:38:16 UTC) #45
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-04 20:47:42 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750483007/220001
3 years, 8 months ago (2017-04-04 20:48:17 UTC) #47
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-04 22:30:43 UTC) #48
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 22:30:44 UTC) #49 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698