Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2750483007: Only show a beforeunload dialog if a frame has been interacted with. (Closed)
Patch Set: rev Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 844 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
845 TwoSubframesCreatePopupsSimultaneously); 845 TwoSubframesCreatePopupsSimultaneously);
846 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 846 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
847 TwoSubframesCreatePopupMenuWidgetsSimultaneously); 847 TwoSubframesCreatePopupMenuWidgetsSimultaneously);
848 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest, 848 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest,
849 CrossSiteIframeAccessibility); 849 CrossSiteIframeAccessibility);
850 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest, 850 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
851 JavaScriptDialogsInMainAndSubframes); 851 JavaScriptDialogsInMainAndSubframes);
852 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 852 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
853 IframeBeforeUnloadParentHang); 853 IframeBeforeUnloadParentHang);
854 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
855 BeforeUnloadDialogRequiresGesture);
854 856
855 // So |find_request_manager_| can be accessed for testing. 857 // So |find_request_manager_| can be accessed for testing.
856 friend class FindRequestManagerTest; 858 friend class FindRequestManagerTest;
857 859
858 // TODO(brettw) TestWebContents shouldn't exist! 860 // TODO(brettw) TestWebContents shouldn't exist!
859 friend class TestWebContents; 861 friend class TestWebContents;
860 862
861 class DestructionObserver; 863 class DestructionObserver;
862 864
863 // Represents a WebContents node in a tree of WebContents structure. 865 // Represents a WebContents node in a tree of WebContents structure.
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
1556 // Adds/removes a callback called on creation of each new WebContents. 1558 // Adds/removes a callback called on creation of each new WebContents.
1557 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1559 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1558 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1560 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1559 1561
1560 DISALLOW_COPY_AND_ASSIGN(FriendWrapper); 1562 DISALLOW_COPY_AND_ASSIGN(FriendWrapper);
1561 }; 1563 };
1562 1564
1563 } // namespace content 1565 } // namespace content
1564 1566
1565 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1567 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698