Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2750363004: PasswordFormManager::form_fetcher_impl_ -> owned_form_fetcher_ (Closed)

Created:
3 years, 9 months ago by vabr (Chromium)
Modified:
3 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PasswordFormManager::form_fetcher_impl_ -> owned_form_fetcher_ This CL renames PasswordFormManager::form_fetcher_impl_ -> owned_form_fetcher_ and, more importantly, changes its type from (a unique_ptr to) FormFetcherImpl to just FormFetcher. The PasswordFormManager does not use the "Impl" part anyway, and the more general type is necessary for coming changes. BUG=621355 Review-Url: https://codereview.chromium.org/2750363004 Cr-Commit-Position: refs/heads/master@{#457776} Committed: https://chromium.googlesource.com/chromium/src/+/8bf230c56d5144b2f11a2371ac9c92158f0a4e4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 2 chunks +2 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi Vasilii, Could you PTAL? Cheers, Vaclav
3 years, 9 months ago (2017-03-17 15:18:17 UTC) #6
vasilii
lgtm
3 years, 9 months ago (2017-03-17 15:26:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750363004/1
3 years, 9 months ago (2017-03-17 15:31:06 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 15:37:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bf230c56d5144b2f11a2371ac9c...

Powered by Google App Engine
This is Rietveld 408576698