components/password_manager/core/browser/password_form_manager.cc - Issue 2750363004: PasswordFormManager::form_fetcher_impl_ -> owned_form_fetcher_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2750363004: PasswordFormManager::form_fetcher_impl_ -> owned_form_fetcher_ (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 0c30c1677cf966e7c3f08c5083081e0d360fde4d..e79ed08bd084cab284037223b3eff8e6f6e0547d 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -24,6 +24,7 @@

#include "components/autofill/core/common/password_form.h"

#include "components/password_manager/core/browser/affiliation_utils.h"

#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"

+#include "components/password_manager/core/browser/form_fetcher_impl.h"

#include "components/password_manager/core/browser/form_saver.h"

#include "components/password_manager/core/browser/log_manager.h"

#include "components/password_manager/core/browser/password_manager.h"

@@ -228,16 +229,16 @@ PasswordFormManager::PasswordFormManager(

submit_result_(kSubmitResultNotSubmitted),

form_type_(kFormTypeUnspecified),

form_saver_(std::move(form_saver)),

- form_fetcher_impl_(form_fetcher

- ? nullptr

- : base::MakeUnique<FormFetcherImpl>(

- PasswordStore::FormDigest(observed_form),

- client,

- /* should_migrate_http_passwords */ true)),

- form_fetcher_(form_fetcher ? form_fetcher : form_fetcher_impl_.get()),

+ owned_form_fetcher_(form_fetcher

+ ? nullptr

+ : base::MakeUnique<FormFetcherImpl>(

+ PasswordStore::FormDigest(observed_form),

+ client,

+ /* should_migrate_http_passwords */ true)),

+ form_fetcher_(form_fetcher ? form_fetcher : owned_form_fetcher_.get()),

is_main_frame_secure_(client->IsMainFrameSecure()) {

- if (form_fetcher_impl_)

- form_fetcher_impl_->Fetch();

+ if (owned_form_fetcher_)

+ owned_form_fetcher_->Fetch();

DCHECK_EQ(observed_form.scheme == PasswordForm::SCHEME_HTML,

driver != nullptr);

if (driver)