Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2750273003: In wpt-update-expectations, ignore tests that unexpectedly pass. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In wpt-update-expectations, ignore tests that unexpectedly pass. In general, when the auto-importer is updating expectations and baselines, if a test unexpectedly passes, then it should be OK to just leave it alone and not update anything. If the pass was a flaky pass, then the previous behavior would have been to try to rebaseline it, which would remove the expectation, which would later cause trouble if the test is flaky. BUG=687442 Review-Url: https://codereview.chromium.org/2750273003 Cr-Commit-Position: refs/heads/master@{#457647} Committed: https://chromium.googlesource.com/chromium/src/+/fb5a41a23dda1f926f1d724650ad63d22bb823ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
qyearsley
3 years, 9 months ago (2017-03-16 23:53:14 UTC) #3
tkent
lgtm
3 years, 9 months ago (2017-03-16 23:55:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750273003/1
3 years, 9 months ago (2017-03-17 00:11:39 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 01:30:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb5a41a23dda1f926f1d724650ad...

Powered by Google App Engine
This is Rietveld 408576698