third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py - Issue 2750273003: In wpt-update-expectations, ignore tests that unexpectedly pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

Issue 2750273003: In wpt-update-expectations, ignore tests that unexpectedly pass. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

index fc8f37b3f12c9911fb6bff306b7eac1dc9119af1..ec019c1245ab0d172cdcce2ede4fd83f83fe46b0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py

@@ -100,7 +100,7 @@ class WPTExpectationsUpdater(object):

_log.warning('No results for build %s', build)

return {}

port_name = self.host.builders.port_name_for_builder_name(build.builder_name)

- test_results = layout_test_results.didnt_run_as_expected_results()

+ test_results = [result for result in layout_test_results.didnt_run_as_expected_results() if not result.did_pass()]

failing_results_dict = self.generate_results_dict(port_name, test_results)

return failing_results_dict

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py » ('j') | no next file with comments »