Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2750243002:
Suppress some flaky WebGL and WebGL2 tests (Closed)
|
Created:
3 years, 9 months ago by ynovikov Modified:
3 years, 9 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSuppress some flaky WebGL and WebGL2 tests
conformance/context/context-eviction-with-garbage-collection.html
on Android NVIDIA Shield.
conformance2/textures/image_bitmap_from_video/:
tex-2d-rgba16f-rgba-float.html
tex-2d-rgba4-rgba-unsigned_byte.html
tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html
on Linux AMD R7 240
BUG=701138, 701929
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2750243002
Cr-Commit-Position: refs/heads/master@{#457335}
Committed: https://chromium.googlesource.com/chromium/src/+/01c438d25416cb64735624b1a0572e0684714330
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (6 generated)
Description was changed from ========== Suppress some flaky WebGL and WebGL2 tests conformance/context/context-eviction-with-garbage-collection.html on Android NVIDIA Shield. conformance2/textures/image_bitmap_from_video/: tex-2d-rgba16f-rgba-float.html tex-2d-rgba4-rgba-unsigned_byte.html tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html on Linux AMD R7 240 BUG=701138, 701929 TBR=kbr@chromium.org ========== to ========== Suppress some flaky WebGL and WebGL2 tests conformance/context/context-eviction-with-garbage-collection.html on Android NVIDIA Shield. conformance2/textures/image_bitmap_from_video/: tex-2d-rgba16f-rgba-float.html tex-2d-rgba4-rgba-unsigned_byte.html tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html on Linux AMD R7 240 BUG=701138, 701929 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by ynovikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Thanks for taking care of this Yuly. https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: ['linux', ('amd', 0x6613)], bug=701138) Are these failing reliably, or could they be marked Flaky instead?
On 2017/03/16 00:41:36, Ken Russell wrote: > LGTM. Thanks for taking care of this Yuly. > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: ['linux', > ('amd', 0x6613)], bug=701138) > Are these failing reliably, or could they be marked Flaky instead? They are Flaky, but I think they are Flaky enough to not bother with "mark as Flaky", "see that it fails 3 retries", "mark as Failed" dance.
On 2017/03/16 00:48:19, ynovikov wrote: > On 2017/03/16 00:41:36, Ken Russell wrote: > > LGTM. Thanks for taking care of this Yuly. > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: ['linux', > > ('amd', 0x6613)], bug=701138) > > Are these failing reliably, or could they be marked Flaky instead? > > They are Flaky, but I think they are Flaky enough to not bother with "mark as > Flaky", "see that it fails 3 retries", "mark as Failed" dance. Like, Linux AMD R7 240 bot is red 99% of the builds. But usually only 1 of these 5 tests fails.
On 2017/03/16 00:49:39, ynovikov wrote: > On 2017/03/16 00:48:19, ynovikov wrote: > > On 2017/03/16 00:41:36, Ken Russell wrote: > > > LGTM. Thanks for taking care of this Yuly. > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: > ['linux', > > > ('amd', 0x6613)], bug=701138) > > > Are these failing reliably, or could they be marked Flaky instead? > > > > They are Flaky, but I think they are Flaky enough to not bother with "mark as > > Flaky", "see that it fails 3 retries", "mark as Failed" dance. > > Like, Linux AMD R7 240 bot is red 99% of the builds. But usually only 1 of these > 5 tests fails. We should ask the Infra Labs team to upgrade the driver on it. Maybe the newer driver's more stable. AMD did just make some fixes in their Windows driver; see https://codereview.chromium.org/2748933004 .
On 2017/03/16 00:51:01, Ken Russell wrote: > On 2017/03/16 00:49:39, ynovikov wrote: > > On 2017/03/16 00:48:19, ynovikov wrote: > > > On 2017/03/16 00:41:36, Ken Russell wrote: > > > > LGTM. Thanks for taking care of this Yuly. > > > > > > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py > (right): > > > > > > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: > > ['linux', > > > > ('amd', 0x6613)], bug=701138) > > > > Are these failing reliably, or could they be marked Flaky instead? > > > > > > They are Flaky, but I think they are Flaky enough to not bother with "mark > as > > > Flaky", "see that it fails 3 retries", "mark as Failed" dance. > > > > Like, Linux AMD R7 240 bot is red 99% of the builds. But usually only 1 of > these > > 5 tests fails. > > We should ask the Infra Labs team to upgrade the driver on it. Maybe the newer > driver's more stable. AMD did just make some fixes in their Windows driver; see > https://codereview.chromium.org/2748933004 . Maybe someone who has the hardware to test a new driver locally could take care of it? I'm not sure what happened when it went red in https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A.... Perhaps it was a driver update which caused this?
On 2017/03/16 00:55:18, ynovikov wrote: > On 2017/03/16 00:51:01, Ken Russell wrote: > > On 2017/03/16 00:49:39, ynovikov wrote: > > > On 2017/03/16 00:48:19, ynovikov wrote: > > > > On 2017/03/16 00:41:36, Ken Russell wrote: > > > > > LGTM. Thanks for taking care of this Yuly. > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py > > (right): > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: > > > ['linux', > > > > > ('amd', 0x6613)], bug=701138) > > > > > Are these failing reliably, or could they be marked Flaky instead? > > > > > > > > They are Flaky, but I think they are Flaky enough to not bother with "mark > > as > > > > Flaky", "see that it fails 3 retries", "mark as Failed" dance. > > > > > > Like, Linux AMD R7 240 bot is red 99% of the builds. But usually only 1 of > > these > > > 5 tests fails. > > > > We should ask the Infra Labs team to upgrade the driver on it. Maybe the newer > > driver's more stable. AMD did just make some fixes in their Windows driver; > see > > https://codereview.chromium.org/2748933004 . > > Maybe someone who has the hardware to test a new driver locally could take care > of it? > I'm not sure what happened when it went red in > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A.... > Perhaps it was a driver update which caused this? I don't think it was a driver update. Per the current logs it's running the Catalyst driver 15.201.1151 which looks like it was released in 2015. The current driver version is 16.60, http://support.amd.com/en-us/kb-articles/Pages/AMDGPU-PRO-Driver-for-Linux-Re... .
On 2017/03/16 01:05:26, Ken Russell wrote: > On 2017/03/16 00:55:18, ynovikov wrote: > > On 2017/03/16 00:51:01, Ken Russell wrote: > > > On 2017/03/16 00:49:39, ynovikov wrote: > > > > On 2017/03/16 00:48:19, ynovikov wrote: > > > > > On 2017/03/16 00:41:36, Ken Russell wrote: > > > > > > LGTM. Thanks for taking care of this Yuly. > > > > > > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py > > > (right): > > > > > > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2750243002/diff/1/content/test/gpu/gpu_tests/... > > > > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:1018: > > > > ['linux', > > > > > > ('amd', 0x6613)], bug=701138) > > > > > > Are these failing reliably, or could they be marked Flaky instead? > > > > > > > > > > They are Flaky, but I think they are Flaky enough to not bother with > "mark > > > as > > > > > Flaky", "see that it fails 3 retries", "mark as Failed" dance. > > > > > > > > Like, Linux AMD R7 240 bot is red 99% of the builds. But usually only 1 of > > > these > > > > 5 tests fails. > > > > > > We should ask the Infra Labs team to upgrade the driver on it. Maybe the > newer > > > driver's more stable. AMD did just make some fixes in their Windows driver; > > see > > > https://codereview.chromium.org/2748933004 . > > > > Maybe someone who has the hardware to test a new driver locally could take > care > > of it? > > I'm not sure what happened when it went red in > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A.... > > Perhaps it was a driver update which caused this? > > I don't think it was a driver update. Per the current logs it's running the > Catalyst driver 15.201.1151 which looks like it was released in 2015. The > current driver version is 16.60, > http://support.amd.com/en-us/kb-articles/Pages/AMDGPU-PRO-Driver-for-Linux-Re... > . Also: apologies but I don't have a local Linux workstation with AMD GPU.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2017/03/16 01:13:30, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) Definitely unrelated. Can't see it showing up for any other try job so just going to retry instead of reporting the flake.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489627945428480, "parent_rev":
"c7a846538699afcb05ba89a8dd8abbf5bbc418ab", "commit_rev":
"01c438d25416cb64735624b1a0572e0684714330"}
Message was sent while issue was closed.
Description was changed from ========== Suppress some flaky WebGL and WebGL2 tests conformance/context/context-eviction-with-garbage-collection.html on Android NVIDIA Shield. conformance2/textures/image_bitmap_from_video/: tex-2d-rgba16f-rgba-float.html tex-2d-rgba4-rgba-unsigned_byte.html tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html on Linux AMD R7 240 BUG=701138, 701929 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Suppress some flaky WebGL and WebGL2 tests conformance/context/context-eviction-with-garbage-collection.html on Android NVIDIA Shield. conformance2/textures/image_bitmap_from_video/: tex-2d-rgba16f-rgba-float.html tex-2d-rgba4-rgba-unsigned_byte.html tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html on Linux AMD R7 240 BUG=701138, 701929 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2750243002 Cr-Commit-Position: refs/heads/master@{#457335} Committed: https://chromium.googlesource.com/chromium/src/+/01c438d25416cb64735624b1a057... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/01c438d25416cb64735624b1a057... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
