|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Ken Russell (switch to Gerrit) Modified:
3 years, 9 months ago CC:
chromium-reviews, piman+watch_chromium.org, sandersd (OOO until July 31) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable NV12 video on newer AMD drivers.
AMD has fixed the underlying bug in their Crimson 17.3.1 driver.
Verified locally.
BUG=644293
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2748933004
Cr-Commit-Position: refs/heads/master@{#457205}
Committed: https://chromium.googlesource.com/chromium/src/+/e1cb39932458b42a69aa5a3c9b353ad383b78a62
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Enable NV12 video on newer AMD drivers. AMD has fixed the underlying bug in their Crimson 17.3.1 driver. Verified locally. BUG=644293 ========== to ========== Enable NV12 video on newer AMD drivers. AMD has fixed the underlying bug in their Crimson 17.3.1 driver. Verified locally. BUG=644293 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + jbauman@chromium.org
PTAL https://codereview.chromium.org/2748933004/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2748933004/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:2396: "value": "21.19.519.2" Note: I'm not sure whether "style": "lexical" is needed here. AMD may have changed their internal version numbering scheme. Will ask them.
The CQ bit was checked by kbr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2748933004/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2748933004/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:2396: "value": "21.19.519.2" On 2017/03/15 04:01:26, Ken Russell wrote: > Note: I'm not sure whether "style": "lexical" is needed here. AMD may have > changed their internal version numbering scheme. Will ask them. Confirmed with AMD that this is correct. The lexical scheme was used on Linux, not Windows.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
sandersd@chromium.org changed reviewers: + sandersd@chromium.org
lgtm
lgtm
Description was changed from ========== Enable NV12 video on newer AMD drivers. AMD has fixed the underlying bug in their Crimson 17.3.1 driver. Verified locally. BUG=644293 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable NV12 video on newer AMD drivers. AMD has fixed the underlying bug in their Crimson 17.3.1 driver. Verified locally. BUG=644293 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489611366430200, "parent_rev":
"709c250de897822863b34fc73e0f15d462507bcf", "commit_rev":
"e1cb39932458b42a69aa5a3c9b353ad383b78a62"}
Message was sent while issue was closed.
Description was changed from ========== Enable NV12 video on newer AMD drivers. AMD has fixed the underlying bug in their Crimson 17.3.1 driver. Verified locally. BUG=644293 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Enable NV12 video on newer AMD drivers. AMD has fixed the underlying bug in their Crimson 17.3.1 driver. Verified locally. BUG=644293 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2748933004 Cr-Commit-Position: refs/heads/master@{#457205} Committed: https://chromium.googlesource.com/chromium/src/+/e1cb39932458b42a69aa5a3c9b35... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e1cb39932458b42a69aa5a3c9b35... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
