Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2750163003: Prevent tabs sync during browser shutdown.

Created:
3 years, 9 months ago by Alexey Seren
Modified:
3 years, 9 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent tabs sync during browser shutdown. Browser shutdown invokes closing of open tabs and firing of OnLocalTabModified event. Thus other clients recieve notifications that all tabs are closed. Current CL fixes this issue. BUG=702604 R=zea@chromium.org, skym@chromium.org

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Alexey Seren
3 years, 9 months ago (2017-03-16 19:25:42 UTC) #1
skym
Hey, I really hate to do this to you, but we're also actively trying to ...
3 years, 9 months ago (2017-03-16 20:18:08 UTC) #3
Alexey Seren
Hello skym! Thank you for reviewing this CL. I can update it basing on WebContentsObserver ...
3 years, 9 months ago (2017-03-17 14:03:51 UTC) #5
Alexey Seren
Hey Skim, You are right about "On startup" setting behaviour. NotificationService have to check it ...
3 years, 9 months ago (2017-03-17 17:42:52 UTC) #6
Patrick Noland
3 years, 9 months ago (2017-03-23 22:43:33 UTC) #7
Now that https://codereview.chromium.org/2753753005/ has landed, you should be
able to rebase this. I'd prefer that you avoid using the Notification Service at
all. Instead I think you can accomplish what you want by checking the browser
count and browser_shutdown::ShutdownType in
BrowserListRouterHelper::OnBrowserRemoved.

Powered by Google App Engine
This is Rietveld 408576698