Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: chrome/browser/sync/test/integration/sync_test.h

Issue 2750163003: Prevent tabs sync during browser shutdown.
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_test.h
diff --git a/chrome/browser/sync/test/integration/sync_test.h b/chrome/browser/sync/test/integration/sync_test.h
index da2ac60d9a4f83090ea9a3676fd5c96ab6be5e32..af11e8757e0565c8a5ab6a730ca88997e59e580d 100644
--- a/chrome/browser/sync/test/integration/sync_test.h
+++ b/chrome/browser/sync/test/integration/sync_test.h
@@ -252,6 +252,8 @@ class SyncTest : public InProcessBrowserTest {
// Triggers a sync for the given |model_types| for the Profile at |index|.
void TriggerSyncForModelTypes(int index, syncer::ModelTypeSet model_types);
+ void TearDownWithSpecificBrowserClose(int index);
+
protected:
// Add custom switches needed for running the test.
virtual void AddTestSwitches(base::CommandLine* cl);
@@ -281,6 +283,9 @@ class SyncTest : public InProcessBrowserTest {
// before the Profile object is created.
void SetPreexistingPreferencesFileContents(const std::string& contents);
+ // Close browser window at index.
+ void CloseBrowserWindowAtIndex(size_t index);
+
// Helper to ProfileManager::CreateProfileAsync that creates a new profile
// used for UI Signin. Blocks until profile is created.
static Profile* MakeProfileForUISignin(base::FilePath profile_path);
@@ -473,6 +478,9 @@ class SyncTest : public InProcessBrowserTest {
// Profile object is created. If empty, no preexisting file will be written.
std::string preexisting_preferences_file_contents_;
+ // Indicies of closed browsers. Stored to eliminate possible re-close.
+ std::set<size_t> closed_browsers_indicies_;
+
DISALLOW_COPY_AND_ASSIGN(SyncTest);
};

Powered by Google App Engine
This is Rietveld 408576698