Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4380)

Unified Diff: chrome/browser/sync/test/integration/sessions_helper.h

Issue 2750163003: Prevent tabs sync during browser shutdown.
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sessions_helper.h
diff --git a/chrome/browser/sync/test/integration/sessions_helper.h b/chrome/browser/sync/test/integration/sessions_helper.h
index b1078b496bef734417409ef029191a7ce431fd6e..4e4ba622fd508eeaa5cff26fe215626ab552b205 100644
--- a/chrome/browser/sync/test/integration/sessions_helper.h
+++ b/chrome/browser/sync/test/integration/sessions_helper.h
@@ -87,6 +87,10 @@ bool OpenTab(int index, const GURL& url);
// size 1, the new tab will be in position 1.
bool OpenTabAtIndex(int index, int tab_index, const GURL& url);
+// Close a tab in the browser at |index| and block until the
+// session model associator is aware of it.
+bool CloseTabAtIndex(int index, int tab_index, const GURL& url);
+
// Moves the tab in position |tab_index| in the TabStrip for browser at
// |from_index| to the TabStrip for browser at |to_index|.
void MoveTab(int from_index, int to_index, int tab_index);
@@ -115,6 +119,10 @@ bool OpenMultipleTabs(int index, const std::vector<GURL>& urls);
// return until each url in |urls| has been found.
bool WaitForTabsToLoad(int index, const std::vector<GURL>& urls);
+// Wait for a session change to propagate to the model associator. Will not
+// return until each url in |urls| has been closed.
+bool WaitForTabsToClose(int index, const std::vector<GURL>& urls);
+
// Check if the session model associator's knows that the current open tab
// has this url.
bool ModelAssociatorHasTabWithUrl(int index, const GURL& url);

Powered by Google App Engine
This is Rietveld 408576698