Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)
Patch Set: Document tests. Use width/height instead of right/bottom, since that's easier to follow. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
index f3f29ac94984384cd4d23a24916d6910392da5ed..248a84399e402f6f20bcc798418970d96a2db23d 100644
--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
@@ -103,7 +103,23 @@ class MultiColumnFragmentainerGroup {
const LayoutRect& boundingBoxInFlowThread) const;
LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const;
- LayoutRect flowThreadPortionOverflowRectAt(unsigned columnIndex) const;
+
+ enum ClipRectAxesSelector {
+ // Only limit the clip rectangle in the block direction. Leave inline
+ // position and length at infinity. Certain operations require this. Those
+ // operations would typically ideally want no clipping at all, but in our
+ // implementation we have to clip in the block direction, in order to slice
+ // the flow thread properly into columns.
+ BlockDirectionAxis,
+
+ // Limit the clip rectangle along both axes. This is what to use for
+ // painting and hit testing.
+ BothAxes
+ };
+
+ LayoutRect flowThreadPortionOverflowRectAt(
+ unsigned columnIndex,
+ ClipRectAxesSelector = BothAxes) const;
// Get the first and the last column intersecting the specified block range.
// Note that |logicalBottomInFlowThread| is an exclusive endpoint.

Powered by Google App Engine
This is Rietveld 408576698