[Payments] Move journey logger to native.

[Payments] Move journey logger to native.

BUG=701042
Review-Url: https://codereview.chromium.org/2750103005
Cr-Commit-Position: refs/heads/master@{#460117}
Committed: https://chromium.googlesource.com/chromium/src/+/0b36e744dc2feabfe8c47f204c6a38098faa513e

[sebsg, 2017-03-23 20:24:03]

Patchset #1 (id:1) has been deleted

[sebsg, 2017-03-23 20:47:22]

Patchset #1 (id:20001) has been deleted

[sebsg, 2017-03-23 20:47:39]

Description was changed from

==========
WIP [Payments] Move journey logger to native.

BUG=
==========

to

==========
[Payments] Move journey logger to native.

BUG=701042
==========

[sebsg, 2017-03-23 20:47:57]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-03-23 20:47:57]

Hi Math, PTAL?

[Mathieu, 2017-03-23 21:19:49]

looking good

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
File
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
would have been great to "git mv" the PaymentRequestJourneyLogger to
JourneyLogger to keep the history of the previous file. Is it too late?

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java:14:
// The index of the different sections of a Payment Request. Used to record
journey stats.
if we are going to mirror these constants to C++, let's add a link that they
should stay in sync to both sides

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
components/payments/content/android/journey_logger_android.h:56:
std::unique_ptr<JourneyLogger> journey_logger_;
Can this be a regular member?

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.cc:146: effect_on_show |=
CMP_SHOW_could_make_payment_;
fix

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.cc:158: 
remove extra line

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.cc:167:
UMA_HISTOGRAM_ENUMERATION(histogram_name, completion_status,
this is wrong. this macro statically caches the histogram name at the call site.


See
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofil...
for how to build the call in this case.

This issue *may* show if you use two JourneyLoggers and attempt to log a
different value. Can you see if a test would uncover that? 

Fix elsewhere in the code too

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:14: // A class to keep track of of
different stats during a Payment Request journey.
nit: of of

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:14: // A class to keep track of of
different stats during a Payment Request journey.
can you mention the usage a little bit? Also, mention when the actual stats are
logged.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:17: // The the different sections of a
Payment Request. Used to record journey
nit: the the

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:43: static const int
CMP_SHOW_could_make_payment_ = 1 << 1;
fix

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:47: ~JourneyLogger(){};
nit: ~JourneyLogger(); and implement in cc

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:83: class SectionStats {
struct?

[sebsg, 2017-03-24 13:34:30]

Patchset #2 (id:60001) has been deleted

[sebsg, 2017-03-24 13:35:30]

Hi Math, another look?

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
File
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> would have been great to "git mv" the PaymentRequestJourneyLogger to
> JourneyLogger to keep the history of the previous file. Is it too late?

Hum, I actually used git mv... Maybe because I changed the name at the same
time?

All the logic has moved out to C++ but I can try if you want.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java:14:
// The index of the different sections of a Payment Request. Used to record
journey stats.
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> if we are going to mirror these constants to C++, let's add a link that they
> should stay in sync to both sides

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/con...
components/payments/content/android/journey_logger_android.h:56:
std::unique_ptr<JourneyLogger> journey_logger_;
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> Can this be a regular member?

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.cc:146: effect_on_show |=
CMP_SHOW_could_make_payment_;
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> fix

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.cc:158: 
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> remove extra line

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.cc:167:
UMA_HISTOGRAM_ENUMERATION(histogram_name, completion_status,
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> this is wrong. this macro statically caches the histogram name at the call
site.
> 
> 
> See
>
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofil...
> for how to build the call in this case.
> 
> This issue *may* show if you use two JourneyLoggers and attempt to log a
> different value. Can you see if a test would uncover that? 
> 
> Fix elsewhere in the code too

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:14: // A class to keep track of of
different stats during a Payment Request journey.
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> nit: of of

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:14: // A class to keep track of of
different stats during a Payment Request journey.
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> can you mention the usage a little bit? Also, mention when the actual stats
are
> logged.

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:17: // The the different sections of a
Payment Request. Used to record journey
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> nit: the the

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:43: static const int
CMP_SHOW_could_make_payment_ = 1 << 1;
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> fix

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:47: ~JourneyLogger(){};
On 2017/03/23 21:19:48, Mathieu (slow - travel) wrote:
> nit: ~JourneyLogger(); and implement in cc

Done.

https://codereview.chromium.org/2750103005/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:83: class SectionStats {
On 2017/03/23 21:19:49, Mathieu (slow - travel) wrote:
> struct?

Done.

[Mathieu, 2017-03-24 13:46:44]

lgtm with nits

https://codereview.chromium.org/2750103005/diff/80001/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/80001/components/payments/con...
components/payments/content/android/journey_logger_android.h:21:
~JourneyLoggerAndroid(){};
nit: add a space and no ;

(here and above)

https://codereview.chromium.org/2750103005/diff/80001/components/payments/cor...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2750103005/diff/80001/components/payments/cor...
components/payments/core/journey_logger.cc:152: LOG(ERROR) << "Effect is " <<
effect_on_show;
remove?

[sebsg, 2017-03-24 13:53:19]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2017-03-24 13:53:19]

Hi Rouslan, PTAL?

https://codereview.chromium.org/2750103005/diff/80001/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/80001/components/payments/con...
components/payments/content/android/journey_logger_android.h:21:
~JourneyLoggerAndroid(){};
On 2017/03/24 13:46:44, Mathieu (slow - travel) wrote:
> nit: add a space and no ;
> 
> (here and above)

Done.

https://codereview.chromium.org/2750103005/diff/80001/components/payments/cor...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2750103005/diff/80001/components/payments/cor...
components/payments/core/journey_logger.cc:152: LOG(ERROR) << "Effect is " <<
effect_on_show;
On 2017/03/24 13:46:44, Mathieu (slow - travel) wrote:
> remove?

Done.

[please use gerrit instead, 2017-03-24 16:31:47]

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
File
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
Either run "git cl upload --similarity=10" to make git detect a copy or change
the year to 2017.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
File components/payments/content/android/journey_logger_android.cc (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.cc:8: #include
"base/strings/string16.h"
Not used.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.cc:83: return
reinterpret_cast<intptr_t>(journey_logger_android);
return reinterpret_cast<jlong>(new JourneyLoggerAndroid);

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:9: #include
<memory>
Not used.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:20:
JourneyLoggerAndroid(JNIEnv* env, jobject unused_obj) {}
1) Please don't inline constructors and destructors in non-trivial classes like
this.
2) Please don't pass in unused parameters into the constructor.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:24: void
Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
Please rename |obj| to |jcaller|. Also below.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:52: static bool
Register(JNIEnv* env);
Statics should be above constructor.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.cc:22: DCHECK(section < SECTION_MAX);
DCHECK_LT(section, SECTION_MAX); 

This makes the failure log easier to read.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:22: // JourneyLogger.java.
Add a mirror comment in JourneyLogger.java. Use the full path in both comments.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:25: enum Sections {
Please use "enum class". Let's use singular "Section" similar to
"CompletionStatus" below, for example.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:49: static const int
CMP_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW = 0;
Let's use "enum class" here as well.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:58: void IncrementSelectionAdds(int
section);
Use the enum type instead of int. Same below.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:80: void
RecordJourneyStatsHistograms(const std::string& submission_type);
Why not use an enum here as well?

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:86: // is still possible to log the
value 0 to that type of histogram.
Note about keeping this in sync with JourneyLogger.java.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:103: int is_requested_;
bool

[sebsg, 2017-03-24 18:34:51]

Patchset #4 (id:100001) has been deleted

[sebsg, 2017-03-24 18:35:09]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 18:36:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-03-24 18:37:47]

Thanks! Another look?

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
File
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java
(right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/java/src/org/chromium/components/payments/JourneyLogger.java:1:
// Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/03/24 16:31:46, ಠ_ಠ slow - w3c wrote:
> Either run "git cl upload --similarity=10" to make git detect a copy or change
> the year to 2017.

Nice it worked! Thanks!

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
File components/payments/content/android/journey_logger_android.cc (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.cc:8: #include
"base/strings/string16.h"
On 2017/03/24 16:31:46, ಠ_ಠ slow - w3c wrote:
> Not used.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.cc:83: return
reinterpret_cast<intptr_t>(journey_logger_android);
On 2017/03/24 16:31:46, ಠ_ಠ slow - w3c wrote:
> return reinterpret_cast<jlong>(new JourneyLoggerAndroid);

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:9: #include
<memory>
On 2017/03/24 16:31:46, ಠ_ಠ slow - w3c wrote:
> Not used.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:20:
JourneyLoggerAndroid(JNIEnv* env, jobject unused_obj) {}
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> 1) Please don't inline constructors and destructors in non-trivial classes
like
> this.
> 2) Please don't pass in unused parameters into the constructor.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:24: void
Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Please rename |obj| to |jcaller|. Also below.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/con...
components/payments/content/android/journey_logger_android.h:52: static bool
Register(JNIEnv* env);
On 2017/03/24 16:31:46, ಠ_ಠ slow - w3c wrote:
> Statics should be above constructor.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.cc:22: DCHECK(section < SECTION_MAX);
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> DCHECK_LT(section, SECTION_MAX); 
> 
> This makes the failure log easier to read.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:22: // JourneyLogger.java.
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Add a mirror comment in JourneyLogger.java. Use the full path in both
comments.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:25: enum Sections {
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Please use "enum class". Let's use singular "Section" similar to
> "CompletionStatus" below, for example.

Unfortunately they have to be implicitly convertible to int to be logged in
UMA...

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:49: static const int
CMP_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW = 0;
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Let's use "enum class" here as well.

I thought it was more clear this way. It allows stuff like

CMP_SHOW_DID_SHOW | CMP_SHOW_COULD_MAKE_PAYMENT

But if you really prefer it to be an enum, I can enumerate the values.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:58: void IncrementSelectionAdds(int
section);
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Use the enum type instead of int. Same below.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:80: void
RecordJourneyStatsHistograms(const std::string& submission_type);
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Why not use an enum here as well?

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:86: // is still possible to log the
value 0 to that type of histogram.
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> Note about keeping this in sync with JourneyLogger.java.

Done.

https://codereview.chromium.org/2750103005/diff/50015/components/payments/cor...
components/payments/core/journey_logger.h:103: int is_requested_;
On 2017/03/24 16:31:47, ಠ_ಠ slow - w3c wrote:
> bool

Done.

[please use gerrit instead, 2017-03-24 19:30:09]

lgtm % comment

https://codereview.chromium.org/2750103005/diff/120001/components/payments/co...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/120001/components/payments/co...
components/payments/content/android/journey_logger_android.h:55: static bool
Register(JNIEnv* env);
Static on top.

[commit-bot: I haz the power, 2017-03-24 21:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:05:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sebsg, 2017-03-27 15:35:11]

sebsg@chromium.org changed reviewers:
+ jwd@chromium.org, tedchoc@chromium.org

[sebsg, 2017-03-27 15:35:12]

Hi tedchoc, could you please review chrome_jni_registrar?

Hi jwd, could you please review histograms.xml?

Thanks!

https://codereview.chromium.org/2750103005/diff/120001/components/payments/co...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2750103005/diff/120001/components/payments/co...
components/payments/content/android/journey_logger_android.h:55: static bool
Register(JNIEnv* env);
On 2017/03/24 19:30:09, ಠ_ಠ slow - w3c wrote:
> Static on top.

Done.

[sebsg, 2017-03-27 15:36:48]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 15:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 16:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 16:57:15]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-03-27 21:48:05]

https://codereview.chromium.org/2750103005/diff/130001/chrome/browser/android...
File chrome/browser/android/chrome_jni_registrar.cc (right):

https://codereview.chromium.org/2750103005/diff/130001/chrome/browser/android...
chrome/browser/android/chrome_jni_registrar.cc:175: #include
"components/payments/content/android/journey_logger_android.h"
If you look at the other components, they have a single registrar method in this
file, but payments is listing all its files here.  We should really add a
payments registrar to keep all of that isolated within the payments component.

[sebsg, 2017-03-28 12:37:27]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 12:37:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 12:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 12:39:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sebsg, 2017-03-28 13:07:04]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 13:07:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 13:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 13:18:18]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sebsg, 2017-03-28 13:31:45]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 13:32:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jwd, 2017-03-28 14:29:46]

histograms lgtm

[commit-bot: I haz the power, 2017-03-28 14:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 14:32:50]

Dry run: This issue passed the CQ dry run.

[sebsg, 2017-03-28 15:20:19]

Thanks Ted, I moved them to their own registrar.

[Ted C, 2017-03-28 15:48:47]

On 2017/03/28 15:20:19, sebsg wrote:
> Thanks Ted, I moved them to their own registrar.

lgtm - thank you!  now it should be even easier to add new payments
functionality

[sebsg, 2017-03-28 15:51:58]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-03-28 15:51:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2750103005/#ps190001
(title: "Add the component_jni_registrar files")

[commit-bot: I haz the power, 2017-03-28 15:52:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:21:45]

CQ is committing da patch.

Bot data: {"patchset_id": 190001, "attempt_start_ts": 1490716318239910,
"parent_rev": "c4da1de6f90c7149e7b2e6db4ee66a84b355988a", "commit_rev":
"0b36e744dc2feabfe8c47f204c6a38098faa513e"}

[commit-bot: I haz the power, 2017-03-28 16:22:28]

Description was changed from

==========
[Payments] Move journey logger to native.

BUG=701042
==========

to

==========
[Payments] Move journey logger to native.

BUG=701042

Review-Url: https://codereview.chromium.org/2750103005
Cr-Commit-Position: refs/heads/master@{#460117}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b36e744dc2feabfe8c47f204c6a...
==========

[commit-bot: I haz the power, 2017-03-28 16:22:32]

Committed patchset #8 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/0b36e744dc2feabfe8c47f204c6a...