chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java - Issue 2750103005: [Payments] Move journey logger to native.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java

Issue 2750103005: [Payments] Move journey logger to native. (Closed)

Patch Set: Add the component_jni_registrar files Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java

index ed3bc15b6f6c727f099174dd8cd913abda1e8bba..66b053b0e33b8b569a6d32b5cffe813e8e1d140c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/ContactDetailsSection.java

@@ -12,7 +12,6 @@ import org.chromium.chrome.browser.payments.AutofillAddress;

import org.chromium.chrome.browser.payments.AutofillContact;

import org.chromium.chrome.browser.payments.ContactEditor;

import org.chromium.chrome.browser.payments.PaymentRequestImpl;

-import org.chromium.chrome.browser.payments.PaymentRequestJourneyLogger;

import java.util.ArrayList;

import java.util.Collection;

@@ -28,7 +27,6 @@ import javax.annotation.Nullable;

public class ContactDetailsSection extends SectionInformation {

private final Context mContext;

private final ContactEditor mContactEditor;

- private final PaymentRequestJourneyLogger mJourneyLogger = new PaymentRequestJourneyLogger();

private List<AutofillProfile> mProfiles;

@@ -135,10 +133,6 @@ public class ContactDetailsSection extends SectionInformation {

if (uniqueContacts.size() == PaymentRequestImpl.SUGGESTIONS_LIMIT) break;

}

- // Log the number of suggested contact infos.

- mJourneyLogger.setNumberOfSuggestionsShown(

- PaymentRequestJourneyLogger.SECTION_CONTACT_INFO, uniqueContacts.size());

// Automatically select the first address if it is complete.

int firstCompleteContactIndex = SectionInformation.NO_SELECTION;

if (!uniqueContacts.isEmpty() && uniqueContacts.get(0).isComplete()) {