Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2750023002: Incognito icon added to Windows taskbar jumplist. (Closed)

Created:
3 years, 9 months ago by Ramin Halavati
Modified:
3 years, 9 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Incognito icon added to Windows taskbar jumplist. On Windows' taskbar's jumplist, both "New window" and "New incognito window" links have main Chrome icon. An Incognito icon is added to the repository and used instead of Chrome icon for new incognito window link. BUG=680904 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2660153002 Cr-Commit-Position: refs/heads/master@{#457032} Committed: https://chromium.googlesource.com/chromium/src/+/596cbc2cc875076c361b1b77e840919a2697b67d patch from issue 2660153002 at patchset 120001 (http://crrev.com/2660153002#ps120001) In the previous attempt to land the CL, I had not updated the DEPS file of src-internal with the new icon and it broke the build. Now the icon is added to Google Chrome by this CL: https://chromereviews.googleplex.com/573787013/ And DEPS file is updated in this CL: https://chromereviews.googleplex.com/569457014/ TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2750023002 Cr-Commit-Position: refs/heads/master@{#457417} Committed: https://chromium.googlesource.com/chromium/src/+/50800dc9e40ad2a4aebd4503dad70b46086a4f6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/app/chrome_exe.rc View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/app/theme/chromium/win/incognito.ico View Binary file 0 comments Download
M chrome/browser/win/jumplist.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_icon_resources_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_icon_resources_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
Ramin Halavati
I have created this CL again after updating the DEPS file of src-internal with the ...
3 years, 9 months ago (2017-03-15 11:43:24 UTC) #3
grt (UTC plus 2)
rubberstamp lgtm
3 years, 9 months ago (2017-03-15 13:34:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750023002/1
3 years, 9 months ago (2017-03-16 11:42:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/387017)
3 years, 9 months ago (2017-03-16 11:47:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750023002/1
3 years, 9 months ago (2017-03-16 13:30:33 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 13:36:23 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50800dc9e40ad2a4aebd4503dad7...

Powered by Google App Engine
This is Rietveld 408576698