Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2749953006: Add download summary notification subtext (Closed)

Created:
3 years, 9 months ago by David Trainor- moved to gerrit
Modified:
3 years, 9 months ago
Reviewers:
qinmin
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add download summary notification subtext The summary notification supports subtext that provides more context for what the notification is. This allows us to say something like "Downloads" which makes it clear what this group of items is. BUG=701989 Review-Url: https://codereview.chromium.org/2749953006 Cr-Commit-Position: refs/heads/master@{#457720} Committed: https://chromium.googlesource.com/chromium/src/+/6017c10d14b38656bb6993ec2ef43d994886fe5d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 2 chunks +3 lines, -4 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
David Trainor- moved to gerrit
ptal https://codereview.chromium.org/2749953006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java (right): https://codereview.chromium.org/2749953006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java#newcode270 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:270: .setSubText(context.getString(R.string.menu_downloads)) Working with team to figure out the ...
3 years, 9 months ago (2017-03-15 22:24:01 UTC) #2
qinmin
lgtm
3 years, 9 months ago (2017-03-16 17:25:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749953006/1
3 years, 9 months ago (2017-03-17 07:46:10 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 09:04:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6017c10d14b38656bb6993ec2ef4...

Powered by Google App Engine
This is Rietveld 408576698