Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Issue 2749953006: Add download summary notification subtext (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
index bc4f784382424a0db1b21f5793fb9004d6b8a614..b6861f250a27545a21385716dc438bd40723ef03 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
@@ -258,9 +258,6 @@ public class DownloadNotificationService extends Service {
* @return a {@link Notification} that represents the summary icon for all downloads.
*/
private static Notification buildSummaryNotificationWithIcon(Context context, int iconId) {
- String title =
- context.getResources().getString(R.string.download_notification_summary_title);
-
ChromeNotificationBuilder builder =
AppHooks.get()
.createChromeNotificationBuilder(true /* preferCompat */,
@@ -268,7 +265,9 @@ public class DownloadNotificationService extends Service {
context.getString(R.string.notification_category_browser),
NotificationConstants.CATEGORY_GROUP_ID_GENERAL,
context.getString(R.string.notification_category_group_general))
- .setContentTitle(title)
+ .setContentTitle(
+ context.getString(R.string.download_notification_summary_title))
+ .setSubText(context.getString(R.string.menu_downloads))
David Trainor- moved to gerrit 2017/03/15 22:24:01 Working with team to figure out the string. Sendi
.setSmallIcon(iconId)
.setLocalOnly(true)
.setGroup(NotificationConstants.GROUP_DOWNLOADS)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698