Issue 2749943004: Show the settings button on a pinned notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2749943004: Show the settings button on a pinned notification. (Closed)

Created:
3 years, 9 months ago by yoshiki

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Show the settings button on a pinned notification. Also some redundant code is removed. BUG=698986 Review-Url: https://codereview.chromium.org/2734933006 Cr-Commit-Position: refs/heads/master@{#456008} (cherry picked from commit c995cd504967cbdead7960097409835d6efde089) Review-Url: https://codereview.chromium.org/2749943004 . Cr-Commit-Position: refs/branch-heads/3029@{#229} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/101d332281f35b1ac45e991a31b19f13707f8808

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -56 lines)			Patch
M	ui/arc/notification/arc_custom_notification_view.h	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	ui/arc/notification/arc_custom_notification_view.cc	View	12 chunks	+53 lines, -54 lines	0 comments	Download
M	ui/message_center/views/padded_button.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

yoshiki

3 years, 9 months ago (2017-03-16 06:27:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
101d332281f35b1ac45e991a31b19f13707f8808.