Show the settings button on a pinned notification.

Show the settings button on a pinned notification.

Also some redundant code is removed.

BUG=698986
Review-Url: https://codereview.chromium.org/2734933006
Cr-Commit-Position: refs/heads/master@{#456008}
Committed: https://chromium.googlesource.com/chromium/src/+/c995cd504967cbdead7960097409835d6efde089

[yhanada, 2017-03-08 11:34:51]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 11:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 12:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 12:01:59]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-03-09 09:38:49]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 09:38:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-03-09 09:39:20]

yhanada@chromium.org changed reviewers:
+ yoshiki@chromium.org

[yhanada, 2017-03-09 09:39:21]

PTAL.

[yhanada, 2017-03-09 10:17:18]

Description was changed from

==========
Show the settings button on a pinned notification.

BUG=698986
==========

to

==========
Show the settings button on a pinned notification.

Also some redundant code is removed.

BUG=698986
==========

[commit-bot: I haz the power, 2017-03-09 11:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 11:15:53]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-03-10 05:27:12]

lgtm with nit

https://codereview.chromium.org/2734933006/diff/20001/ui/arc/notification/arc...
File ui/arc/notification/arc_custom_notification_view.h (right):

https://codereview.chromium.org/2734933006/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_custom_notification_view.h:128:
std::unique_ptr<ControlButton> close_button_ = nullptr;
nit : "= nullptr" is not necessary.

[yhanada, 2017-03-10 05:44:04]

On 2017/03/10 05:27:12, yoshiki wrote:
> lgtm with nit
> 
>
https://codereview.chromium.org/2734933006/diff/20001/ui/arc/notification/arc...
> File ui/arc/notification/arc_custom_notification_view.h (right):
> 
>
https://codereview.chromium.org/2734933006/diff/20001/ui/arc/notification/arc...
> ui/arc/notification/arc_custom_notification_view.h:128:
> std::unique_ptr<ControlButton> close_button_ = nullptr;
> nit : "= nullptr" is not necessary.

Thank you for reviewing!

[yhanada, 2017-03-10 05:44:12]

https://codereview.chromium.org/2734933006/diff/20001/ui/arc/notification/arc...
File ui/arc/notification/arc_custom_notification_view.h (right):

https://codereview.chromium.org/2734933006/diff/20001/ui/arc/notification/arc...
ui/arc/notification/arc_custom_notification_view.h:128:
std::unique_ptr<ControlButton> close_button_ = nullptr;
On 2017/03/10 05:27:12, yoshiki wrote:
> nit : "= nullptr" is not necessary.

Done.

[yhanada, 2017-03-10 05:44:18]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-03-10 05:44:18]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2734933006/#ps40001
(title: "Show the settings button on a pinned notification.")

[commit-bot: I haz the power, 2017-03-10 05:44:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 06:25:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489124658049380,
"parent_rev": "75fc67d070979f30b49c1b272c0d9c64211aa6e9", "commit_rev":
"c995cd504967cbdead7960097409835d6efde089"}

[commit-bot: I haz the power, 2017-03-10 06:26:20]

Description was changed from

==========
Show the settings button on a pinned notification.

Also some redundant code is removed.

BUG=698986
==========

to

==========
Show the settings button on a pinned notification.

Also some redundant code is removed.

BUG=698986

Review-Url: https://codereview.chromium.org/2734933006
Cr-Commit-Position: refs/heads/master@{#456008}
Committed:
https://chromium.googlesource.com/chromium/src/+/c995cd504967cbdead7960097409...
==========

[commit-bot: I haz the power, 2017-03-10 06:26:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c995cd504967cbdead7960097409...