cc: Fix a flake in ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

cc: Fix a flake in ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

ThreadChecker can't be used to check for "false", since debug implementations
always return true. This patch fixes that by using ThreadCheckerImpl instead.
The reason it is a flake and not a consistent repro is that the function may
or may not have run (this is expected by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2749933002
Cr-Commit-Position: refs/heads/master@{#457135}
Committed: https://chromium.googlesource.com/chromium/src/+/9eff7fc87045e048e489824abc6c1be9403ef7bc

[vmpstr, 2017-03-14 21:08:16]

Description was changed from

==========
cc: Fix a flake in
ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

thread_checker can't be used to check for "false", since debug implementations
always return true. This patch fixes that. The reason it is a flake and not a
consistent repro is that the function may or may not have run (this is expected
by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
==========

to

==========
cc: Fix a flake in
ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

thread_checker can't be used to check for "false", since debug implementations
always return true. This patch fixes that. The reason it is a flake and not a
consistent repro is that the function may or may not have run (this is expected
by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-03-14 21:08:40]

Please take a look.

[danakj, 2017-03-14 21:10:12]

LGTM

https://codereview.chromium.org/2749933002/diff/1/cc/tiles/image_controller_u...
File cc/tiles/image_controller_unittest.cc (left):

https://codereview.chromium.org/2749933002/diff/1/cc/tiles/image_controller_u...
cc/tiles/image_controller_unittest.cc:193:
EXPECT_FALSE(thread_checker_.CalledOnValidThread());
You could #if DCHECK_IS_ON() or smoething if u want

[danakj, 2017-03-14 21:10:46]

https://codereview.chromium.org/2749933002/diff/1/cc/tiles/image_controller_u...
File cc/tiles/image_controller_unittest.cc (left):

https://codereview.chromium.org/2749933002/diff/1/cc/tiles/image_controller_u...
cc/tiles/image_controller_unittest.cc:193:
EXPECT_FALSE(thread_checker_.CalledOnValidThread());
On 2017/03/14 21:10:11, danakj wrote:
> You could #if DCHECK_IS_ON() or smoething if u want

You can also use ThreadCheckerImpl if you want

[vmpstr, 2017-03-15 17:41:05]

Description was changed from

==========
cc: Fix a flake in
ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

thread_checker can't be used to check for "false", since debug implementations
always return true. This patch fixes that. The reason it is a flake and not a
consistent repro is that the function may or may not have run (this is expected
by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix a flake in
ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

ThreadChecker can't be used to check for "false", since debug implementations
always return true. This patch fixes that by using ThreadCheckerImpl instead.
The reason it is a flake and not a consistent repro is that the function may
or may not have run (this is expected by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-03-15 17:41:57]

https://codereview.chromium.org/2749933002/diff/1/cc/tiles/image_controller_u...
File cc/tiles/image_controller_unittest.cc (left):

https://codereview.chromium.org/2749933002/diff/1/cc/tiles/image_controller_u...
cc/tiles/image_controller_unittest.cc:193:
EXPECT_FALSE(thread_checker_.CalledOnValidThread());
On 2017/03/14 21:10:46, danakj wrote:
> On 2017/03/14 21:10:11, danakj wrote:
> > You could #if DCHECK_IS_ON() or smoething if u want
> 
> You can also use ThreadCheckerImpl if you want

Good idea. I did ThreadCheckerImpl instead.

[vmpstr, 2017-03-15 17:42:00]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-03-15 17:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2749933002/#ps20001
(title: "threadcheckerimpl")

[commit-bot: I haz the power, 2017-03-15 17:42:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 17:57:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489599720045780,
"parent_rev": "fbd79f5f4204abdd4d3b61bf55ccaadb5402dd01", "commit_rev":
"9eff7fc87045e048e489824abc6c1be9403ef7bc"}

[commit-bot: I haz the power, 2017-03-15 17:58:11]

Description was changed from

==========
cc: Fix a flake in
ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

ThreadChecker can't be used to check for "false", since debug implementations
always return true. This patch fixes that by using ThreadCheckerImpl instead.
The reason it is a flake and not a consistent repro is that the function may
or may not have run (this is expected by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix a flake in
ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

ThreadChecker can't be used to check for "false", since debug implementations
always return true. This patch fixes that by using ThreadCheckerImpl instead.
The reason it is a flake and not a consistent repro is that the function may
or may not have run (this is expected by tests).

BUG=701065
R=ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2749933002
Cr-Commit-Position: refs/heads/master@{#457135}
Committed:
https://chromium.googlesource.com/chromium/src/+/9eff7fc87045e048e489824abc6c...
==========

[commit-bot: I haz the power, 2017-03-15 17:58:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9eff7fc87045e048e489824abc6c...