cc: Fix a flake in ImageControllerTest.QueueImageDecodeChangeControllerWithTaskQueued

cc/tiles/image_controller_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/tiles/image_controller.h"
 #include "base/bind.h"
 #include "base/optional.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/sequenced_task_runner_handle.h"
@@ skipping 172 matching lines @@
 // A task that blocks until instructed otherwise.
 class BlockingTask : public TileTask {
  public:
   BlockingTask()
       : TileTask(true /* supports_concurrent_execution */), run_cv_(&lock_) {
     EXPECT_TRUE(thread_checker_.CalledOnValidThread());
   }
 
   void RunOnWorkerThread() override {
     EXPECT_FALSE(HasCompleted());
-    EXPECT_FALSE(thread_checker_.CalledOnValidThread());

[danakj, 2017/03/14 21:10:11]

You could #if DCHECK_IS_ON() or smoething if u want

[danakj, 2017/03/14 21:10:46]

You can also use ThreadCheckerImpl if you want

[vmpstr, 2017/03/15 17:41:57]

Good idea. I did ThreadCheckerImpl instead.

     base::AutoLock hold(lock_);
     if (!can_run_)
       run_cv_.Wait();
     has_run_ = true;
   }
 
   void OnTaskCompleted() override {
     EXPECT_TRUE(thread_checker_.CalledOnValidThread());
   }
 
@@ skipping 378 matching lines @@
             decode_client2.result());
 
   // Reset the controller since the order of destruction is wrong in this test
   // (|other_cache| should outlive the controller. This is normally done via
   // SetImageDecodeCache(nullptr) or it can be done in the dtor of the cache.)
   ResetController();
 }
 
 }  // namespace
 }  // namespace cc