Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2749913002: MD Settings: Improve People Page Manage Profile button accessibility (Closed)

Created:
3 years, 9 months ago by tommycli
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Improve People Page Manage Profile button accessibility Previous aria-label was not very descriptive. BUG=693375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2749913002 Cr-Commit-Position: refs/heads/master@{#456819} Committed: https://chromium.googlesource.com/chromium/src/+/97ccfb795e4bf6b9e65eb63e9eea9c71577cc47d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tommycli
dbeam: PTAL, thanks!
3 years, 9 months ago (2017-03-14 19:27:11 UTC) #5
Dan Beam
lgtm
3 years, 9 months ago (2017-03-14 19:53:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749913002/1
3 years, 9 months ago (2017-03-14 20:27:41 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 20:53:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97ccfb795e4bf6b9e65eb63e9eea...

Powered by Google App Engine
This is Rietveld 408576698