Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2749913002: MD Settings: Improve People Page Manage Profile button accessibility (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index a4bc33b71b800cc8edfd5615eef59191070f0af4..9ffd5fda656d214ed70992fbe70a7f0927b95588 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -123,14 +123,20 @@
</if>
<div class="flex text-elide">
<span id="profile-name">[[profileName_]]</span>
- <div class="secondary" hidden="[[!syncStatus.signedIn]]"
- id="profileNameSecondary">
+ <div class="secondary" hidden="[[!syncStatus.signedIn]]">
[[syncStatus.signedInUsername]]
</div>
</div>
+<if expr="not chromeos">
<button class="subpage-arrow" is="paper-icon-button-light"
- aria-labelledby="profile-name"
- aria-describedby="profileNameSecondary"></button>
+ aria-label="$i18n{editPerson}"
+ aria-describedby="profile-name"></button>
+</if>
+<if expr="chromeos">
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{changePictureTitle}"
+ aria-describedby="profile-name"></button>
+</if>
</div>
<if expr="not chromeos">
<template is="dom-if" if="[[showSignin_(syncStatus)]]">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698