Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2749893004:
Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. (Closed)
|
Created:
3 years, 9 months ago by Guido Urdaneta Modified:
3 years, 9 months ago Reviewers:
hbos_chromium CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, hta - Chromium Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not ask for permissions if getUserMedia() video-device constraints cannot be satisfied.
This is a step towards making getUserMedia() more spec-compliant.
See https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia
BUG=690491
Review-Url: https://codereview.chromium.org/2749893004
Cr-Commit-Position: refs/heads/master@{#457746}
Committed: https://chromium.googlesource.com/chromium/src/+/cdf688e90e2425c5af4f3450997c83b4dd903a56
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 26 (21 generated)
Description was changed from ========== Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. This is a step to make getUserMedia() more spec-compliant. BUG=690491 ========== to ========== Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. This is a step towards making getUserMedia() more spec-compliant. BUG=690491 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
guidou@chromium.org changed reviewers: + hbos@chromium.org
Hi, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by guidou@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm nit: Add link to the spec you're referring to in the CL description when you say "more spec-compliant"
Description was changed from ========== Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. This is a step towards making getUserMedia() more spec-compliant. BUG=690491 ========== to ========== Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. This is a step towards making getUserMedia() more spec-compliant. See https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia BUG=690491 ==========
On 2017/03/17 11:17:52, hbos_chromium wrote: > lgtm > > nit: Add link to the spec you're referring to in the CL description when you say > "more spec-compliant" done
The CQ bit was checked by guidou@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489752821325470,
"parent_rev": "6f8c23bd5124fa128de72da19d6b1f50e22d52cc", "commit_rev":
"cdf688e90e2425c5af4f3450997c83b4dd903a56"}
Message was sent while issue was closed.
Description was changed from ========== Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. This is a step towards making getUserMedia() more spec-compliant. See https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia BUG=690491 ========== to ========== Do not ask for permissions if getUserMedia() video-device constraints cannot be satisfied. This is a step towards making getUserMedia() more spec-compliant. See https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia BUG=690491 Review-Url: https://codereview.chromium.org/2749893004 Cr-Commit-Position: refs/heads/master@{#457746} Committed: https://chromium.googlesource.com/chromium/src/+/cdf688e90e2425c5af4f3450997c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/chromium/src/+/cdf688e90e2425c5af4f3450997c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
