Minor refactoring of SelectSettings results for consistency.

Minor refactoring of SelectSettings results for consistency.

Make VideoDeviceCaptureSourceSelectionResult a class, and update some
documentation. In line with VideoContentCaptureSourceSelectionResult.

This is in anticipation to the addition of support for track settings.

BUG=657733
Review-Url: https://codereview.chromium.org/2751643003
Cr-Commit-Position: refs/heads/master@{#457268}
Committed: https://chromium.googlesource.com/chromium/src/+/2ca03688be282be7b59aadc46489823e9ebcf3bd

[Guido Urdaneta, 2017-03-14 18:38:15]

Description was changed from

==========
Minor refactoring of SelectSettings results for consistency.

Make VideoDeviceCaptureSourceSelectionResult a class, and update some
documentation. In line with VideoContentCaptureSourceSelectionResult.

This is in anticipation to the addition of support for track settings.

BUG=657733
==========

to

==========
Minor refactoring of SelectSettings results for consistency.

Make VideoDeviceCaptureSourceSelectionResult a class, and update some
documentation. In line with VideoContentCaptureSourceSelectionResult.

This is in anticipation to the addition of support for track settings.

BUG=657733
==========

[Guido Urdaneta, 2017-03-14 18:38:16]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org

[Guido Urdaneta, 2017-03-14 18:38:43]

Hi, PTAL

[hbos_chromium, 2017-03-15 07:54:27]

lgtm

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_constraints_util_video_device.cc
(right):

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_video_device.cc:761: const
std::string& device_id,
|device_id| is passed as a const& and isn't moved, update comment. But then
again, if changed to using std::string I think the fact that it is moved is an
implementation detail because it doesn't affect the caller. I would not say
anything about moving.

This comment is in both .h and .cc, it should only be in .h.

[hta - Chromium, 2017-03-15 11:55:07]

hta@chromium.org changed reviewers:
+ hta@chromium.org

[hta - Chromium, 2017-03-15 11:55:08]

lgtm

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_constraints_util_video_device.h
(right):

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_video_device.h:45:
VideoDeviceCaptureSourceSelectionResult();
Can we remove this constructor, since it creates an object in an inconsistent
state, and we have removed the ability to change it?

[Guido Urdaneta, 2017-03-15 19:15:32]

Patchset #2 (id:20001) has been deleted

[Guido Urdaneta, 2017-03-15 19:16:47]

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_constraints_util_video_device.cc
(right):

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_video_device.cc:761: const
std::string& device_id,
On 2017/03/15 07:54:27, hbos_chromium wrote:
> |device_id| is passed as a const& and isn't moved, update comment. But then
> again, if changed to using std::string I think the fact that it is moved is an
> implementation detail because it doesn't affect the caller. I would not say
> anything about moving.
> 
> This comment is in both .h and .cc, it should only be in .h.

Done.

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_constraints_util_video_device.h
(right):

https://codereview.chromium.org/2751643003/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_constraints_util_video_device.h:45:
VideoDeviceCaptureSourceSelectionResult();
On 2017/03/15 11:55:08, hta - Chromium wrote:
> Can we remove this constructor, since it creates an object in an inconsistent
> state, and we have removed the ability to change it?

My original intention was to remove it, but we need it because
PostTaskAndReplyWithResult requires it to have a default constructor.
It is used here:
https://cs.chromium.org/chromium/src/content/renderer/media/user_media_client...

Also, the state is technically not inconsistent because the HasValue() method
returns false, so the other fields do not have any meaningful values and should
not be read.

[Guido Urdaneta, 2017-03-15 22:03:58]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 22:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 22:39:45]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Guido Urdaneta, 2017-03-15 22:47:56]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-03-15 22:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@chromium.org,
hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2751643003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-15 22:48:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:53:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489618076141320,
"parent_rev": "f0b3c0982895cc340125f558b0f978c53e7543f2", "commit_rev":
"2ca03688be282be7b59aadc46489823e9ebcf3bd"}

[commit-bot: I haz the power, 2017-03-15 23:53:51]

Description was changed from

==========
Minor refactoring of SelectSettings results for consistency.

Make VideoDeviceCaptureSourceSelectionResult a class, and update some
documentation. In line with VideoContentCaptureSourceSelectionResult.

This is in anticipation to the addition of support for track settings.

BUG=657733
==========

to

==========
Minor refactoring of SelectSettings results for consistency.

Make VideoDeviceCaptureSourceSelectionResult a class, and update some
documentation. In line with VideoContentCaptureSourceSelectionResult.

This is in anticipation to the addition of support for track settings.

BUG=657733

Review-Url: https://codereview.chromium.org/2751643003
Cr-Commit-Position: refs/heads/master@{#457268}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ca03688be282be7b59aadc46489...
==========

[commit-bot: I haz the power, 2017-03-15 23:53:52]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2ca03688be282be7b59aadc46489...