Move Ozone GPU initialization.

Move Ozone GPU initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142, 620934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2749873002
Cr-Commit-Position: refs/heads/master@{#457266}
Committed: https://chromium.googlesource.com/chromium/src/+/002b2ee07c580e92cefa2fbc7c067af40c367c44

[kylechar, 2017-03-15 14:20:53]

Description was changed from

==========
Move Ozone GL initialization.

WIP.

BUG=
==========

to

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the gpu main or test main call the Ozone initialize. This
way gpu main ca nset single_process to false and tests can set
single_process to true.

Since this CL updates all callers to OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142
==========

[kylechar, 2017-03-15 14:23:22]

Description was changed from

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the gpu main or test main call the Ozone initialize. This
way gpu main ca nset single_process to false and tests can set
single_process to true.

Since this CL updates all callers to OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142
==========

to

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the gpu main or test main call the Ozone initialize. This
way gpu main can set InitParams::single_process to false and tests can
set InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
==========

[kylechar, 2017-03-15 14:49:00]

Description was changed from

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the gpu main or test main call the Ozone initialize. This
way gpu main can set InitParams::single_process to false and tests can
set InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
==========

to

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
==========

[kylechar, 2017-03-15 14:49:25]

Description was changed from

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
==========

to

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2017-03-15 18:50:02]

Patchset #4 (id:60001) has been deleted

[kylechar, 2017-03-15 18:50:35]

kylechar@chromium.org changed reviewers:
+ piman@chromium.org, rjkroege@chromium.org

[kylechar, 2017-03-15 18:50:36]

piman: content/gpu/*, gpu/ipc/service/*, ui/gl/*
rjkroege: ui/ozone/*

[kylechar, 2017-03-15 18:50:52]

Description was changed from

==========
Move Ozone GL initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move Ozone GPU initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[rjkroege, 2017-03-15 19:18:51]

lgtm

[piman, 2017-03-15 19:48:21]

https://codereview.chromium.org/2749873002/diff/80001/gpu/ipc/service/gpu_ini...
File gpu/ipc/service/gpu_init.cc (right):

https://codereview.chromium.org/2749873002/diff/80001/gpu/ipc/service/gpu_ini...
gpu/ipc/service/gpu_init.cc:183: // Initialize Ozone GPU after the watchdog and
sandbox are started.
The sandbox is generally not started at this point (early sandbox is the
exception for a couple of drivers that create threads).
I think this is still ok (since it used to be in InitializeGLOneOff right
below), but you may want to update the comment to reflect what's really
happening.

https://codereview.chromium.org/2749873002/diff/80001/ui/gl/test/gl_image_tes...
File ui/gl/test/gl_image_test_support.cc (right):

https://codereview.chromium.org/2749873002/diff/80001/ui/gl/test/gl_image_tes...
ui/gl/test/gl_image_test_support.cc:24: params.single_process = false;
true?
Unit tests run in single-process mode.

[kylechar, 2017-03-15 20:59:08]

https://codereview.chromium.org/2749873002/diff/80001/gpu/ipc/service/gpu_ini...
File gpu/ipc/service/gpu_init.cc (right):

https://codereview.chromium.org/2749873002/diff/80001/gpu/ipc/service/gpu_ini...
gpu/ipc/service/gpu_init.cc:183: // Initialize Ozone GPU after the watchdog and
sandbox are started.
On 2017/03/15 19:48:21, piman wrote:
> The sandbox is generally not started at this point (early sandbox is the
> exception for a couple of drivers that create threads).
> I think this is still ok (since it used to be in InitializeGLOneOff right
> below), but you may want to update the comment to reflect what's really
> happening.

Thanks for the clarification, I changed the comment.

https://codereview.chromium.org/2749873002/diff/80001/ui/gl/test/gl_image_tes...
File ui/gl/test/gl_image_test_support.cc (right):

https://codereview.chromium.org/2749873002/diff/80001/ui/gl/test/gl_image_tes...
ui/gl/test/gl_image_test_support.cc:24: params.single_process = false;
On 2017/03/15 19:48:21, piman wrote:
> true?
> Unit tests run in single-process mode.

Whoops. Done.

[piman, 2017-03-15 21:01:25]

lgtm

[kylechar, 2017-03-15 21:18:38]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:19:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:50:16]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489612718291180,
"parent_rev": "05cf8760ae525d87b0ec465ef019bb1de38bbf93", "commit_rev":
"002b2ee07c580e92cefa2fbc7c067af40c367c44"}

[commit-bot: I haz the power, 2017-03-15 23:50:54]

Description was changed from

==========
Move Ozone GPU initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move Ozone GPU initialization.

Right now OzonePlatform::InitializeForGPU() gets called as part of
gl::init::GetAllowedGLImplementations(). We need to properly set
InitParams when initializing the Ozone GPU so the platform knows if it
should expect to be running in a single process.

Instead, have the GpuInit or tests call InitializeForGPU(). This way
GpuInit can set InitParams::single_process to false and tests can set
InitParams::single_process to true.

Since this CL updates all callers of OzonePlatform::InitializeForGPU()
to use the new version, we can also delete the deprecated version of the
function.

BUG=700142,620934
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2749873002
Cr-Commit-Position: refs/heads/master@{#457266}
Committed:
https://chromium.googlesource.com/chromium/src/+/002b2ee07c580e92cefa2fbc7c06...
==========

[commit-bot: I haz the power, 2017-03-15 23:50:55]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/002b2ee07c580e92cefa2fbc7c06...