Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2749863006: Revert of Fix overflow:overlay scrollbar width for paint. (Closed)

Created:
3 years, 9 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
pdr., skobes, szager1
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix overflow:overlay scrollbar width for paint. (patchset #6 id:100001 of https://codereview.chromium.org/2730343003/ ) Reason for revert: A layout test gets red after this CL due to the mismatched test expectation. The error log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13521 fast/overflow/scroll-nested-positioned-layer-in-overflow.html Original issue's description: > Fix overflow:overlay scrollbar width for paint. > > This CL went too far: > > https://codereview.chromium.org/2725763002 > > Some callers to verticalScrollbarWidth -- in particular, the paint > code -- need the old behavior, where overflow:overlay scrollbars > are subtracted from the overflow clip rect. > > BUG=697751 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2730343003 > Cr-Commit-Position: refs/heads/master@{#457251} > Committed: https://chromium.googlesource.com/chromium/src/+/7ab46eae8507137607e258543118ef8fb04984de TBR=pdr@chromium.org,skobes@chromium.org,szager@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697751 Review-Url: https://codereview.chromium.org/2749863006 Cr-Commit-Position: refs/heads/master@{#457322} Committed: https://chromium.googlesource.com/chromium/src/+/939b298311ed40bf5752b47db5e7a2b2d9db3431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -80 lines) Patch
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-overlay-with-touch-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipRectsCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 3 chunks +9 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollTypes.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tzik
Created Revert of Fix overflow:overlay scrollbar width for paint.
3 years, 9 months ago (2017-03-16 02:27:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749863006/1
3 years, 9 months ago (2017-03-16 02:28:16 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:30:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/939b298311ed40bf5752b47db5e7...

Powered by Google App Engine
This is Rietveld 408576698