Account for overlay scrollbars when computing scrollbar width/height.

Account for overlay scrollbars when computing scrollbar width/height.

This specifically addresses overlay scrollbars created via css with
overflow:overlay.  In some places, those scrollbars are treated
differently from overlay scrollbars created by the platform theme
(e.g., on mac).

BUG=657718
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2725763002
Cr-Commit-Position: refs/heads/master@{#454105}
Committed: https://chromium.googlesource.com/chromium/src/+/5a729d1bc790d94120ec942a4566bb85f969cdb1

[szager1, 2017-03-01 00:00:39]

Description was changed from

==========
Account for overlay scrollbars when computing scrollbar width/height.

BUG=657718
R=skobes@chromium.org
==========

to

==========
Account for overlay scrollbars when computing scrollbar width/height.

BUG=657718
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-03-01 00:01:33]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 00:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 00:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:34:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[szager1, 2017-03-01 20:25:05]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:25:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:28:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[skobes, 2017-03-01 20:52:35]

Bots look red.

Change description should refer to "overflow: overlay" scrollbars, which are a
much stranger beast than overlay scrollbars in general.

[szager1, 2017-03-01 21:14:56]

Description was changed from

==========
Account for overlay scrollbars when computing scrollbar width/height.

BUG=657718
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Account for overlay scrollbars when computing scrollbar width/height.

This specifically addresses overlay scrollbars created via css with
overflow:overlay.  In some places, those scrollbars are treated
differently from overlay scrollbars created by the platform theme
(e.g., on mac).

BUG=657718
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[szager1, 2017-03-01 21:19:15]

The CQ bit was checked by szager@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 21:20:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2017-03-01 22:15:38]

On 2017/03/01 20:52:35, skobes wrote:
> Bots look red.
> 
> Change description should refer to "overflow: overlay" scrollbars, which are a
> much stranger beast than overlay scrollbars in general.

Updated description and rebased; PTAL.

[skobes, 2017-03-01 22:23:56]

lgtm

[commit-bot: I haz the power, 2017-03-01 22:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:57:28]

Dry run: This issue passed the CQ dry run.

[szager1, 2017-03-01 23:47:27]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2017-03-01 23:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 23:56:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488412047678200,
"parent_rev": "d25c0f20455f2a7399ffa9e097b0c14f25e18d40", "commit_rev":
"5a729d1bc790d94120ec942a4566bb85f969cdb1"}

[commit-bot: I haz the power, 2017-03-01 23:57:20]

Description was changed from

==========
Account for overlay scrollbars when computing scrollbar width/height.

This specifically addresses overlay scrollbars created via css with
overflow:overlay.  In some places, those scrollbars are treated
differently from overlay scrollbars created by the platform theme
(e.g., on mac).

BUG=657718
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Account for overlay scrollbars when computing scrollbar width/height.

This specifically addresses overlay scrollbars created via css with
overflow:overlay.  In some places, those scrollbars are treated
differently from overlay scrollbars created by the platform theme
(e.g., on mac).

BUG=657718
R=skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2725763002
Cr-Commit-Position: refs/heads/master@{#454105}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a729d1bc790d94120ec942a4566...
==========

[commit-bot: I haz the power, 2017-03-01 23:57:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5a729d1bc790d94120ec942a4566...

[tzik, 2017-03-16 02:08:05]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2757513002/ by tzik@chromium.org.

The reason for reverting is: A layout test gets red after this CL due to the
mismatched test expectation.

The error log is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....

[tzik, 2017-03-16 02:24:55]

On 2017/03/16 02:08:05, tzik wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2757513002/ by mailto:tzik@chromium.org.
> 
> The reason for reverting is: A layout test gets red after this CL due to the
> mismatched test expectation.
> 
> The error log is:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....

Cancelled the revert. Sorry, I clicked wrong link in a failure log.