Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2749863004: Remove screen_orientation_messages.h. (Closed)

Created:
3 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-screen-orientation_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove screen_orientation_messages.h. This CL is a follow-up of https://codereview.chromium.org/2745443002. blink::WebScreenOrientationLockType traits is defined in screen_orientation_messages.h but has only one user: manifest_manager_messages.h, so we just move it into manifest_manager_messages.h, thus screen_orientation_messages.h becomes empty and we can remove it completely. BUG=678545 Review-Url: https://codereview.chromium.org/2749863004 Cr-Commit-Position: refs/heads/master@{#457344} Committed: https://chromium.googlesource.com/chromium/src/+/880b3a975ba7d0a4eda16332bcb8bac63f561405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/manifest_manager_messages.h View 1 chunk +4 lines, -0 lines 0 comments Download
D content/common/screen_orientation_messages.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
leonhsl(Using Gerrit)
Hi, Tom, this is the follow-up CL I promised in https://codereview.chromium.org/2745443002/ :) PTAL, Thanks!
3 years, 9 months ago (2017-03-15 10:36:08 UTC) #10
mlamouri (slow - plz ping)
lgtm
3 years, 9 months ago (2017-03-15 10:50:48 UTC) #12
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-15 16:18:59 UTC) #13
leonhsl(Using Gerrit)
+kinuko@, would you PTAL for OWNER review of files other than *_messages.h? Thanks!
3 years, 9 months ago (2017-03-16 03:36:33 UTC) #15
kinuko
lgtm
3 years, 9 months ago (2017-03-16 03:53:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749863004/1
3 years, 9 months ago (2017-03-16 03:55:28 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 04:03:55 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/880b3a975ba7d0a4eda16332bcb8...

Powered by Google App Engine
This is Rietveld 408576698