chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/engagement/site_engagement_service_unittest.cc ('K') | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc » ('j') | chrome/browser/password_manager/password_manager_internals_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

index 0c6dad3e6e4ceb9e1d08403df6d973437230aa5c..c3e0b9d63f0a290815f214872d2e7d718dd49edf 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

@@ -68,6 +68,7 @@ class SignedInDevicesManager : public BrowserContextKeyedAPI,

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<SignedInDevicesManager>*

GetFactoryInstance();

+ void Shutdown() override;

// ExtensionRegistryObserver implementation.

void OnExtensionUnloaded(content::BrowserContext* browser_context,