chrome/browser/extensions/api/input_ime/input_ime_api.cc - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api.cc

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/input_ime/input_ime_api.cc

diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.cc b/chrome/browser/extensions/api/input_ime/input_ime_api.cc

index 712584d1949423ab48a904df8343e5fe96ea60a4..70a01b69bdb23ea4020b8481b850d5b74b994981 100644

--- a/chrome/browser/extensions/api/input_ime/input_ime_api.cc

+++ b/chrome/browser/extensions/api/input_ime/input_ime_api.cc

@@ -416,7 +416,9 @@ void InputImeAPI::Observe(int type,

content::Source<Profile>(source).ptr());

}

-InputImeAPI::~InputImeAPI() {

+InputImeAPI::~InputImeAPI() = default;

+void InputImeAPI::Shutdown() {

EventRouter::Get(browser_context_)->UnregisterObserver(this);

registrar_.RemoveAll();

}