chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/engagement/site_engagement_service_unittest.cc ('K') | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h ('k') | chrome/browser/extensions/extension_gcm_app_handler.h » ('j') | chrome/browser/password_manager/password_manager_internals_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

index 49e4abd861ed823692dba461e49251a6edd5fb53..c8feb049305ff7dec9a9d4690cf8bca904dd856e 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

@@ -114,7 +114,9 @@ SignedInDevicesManager::SignedInDevicesManager(content::BrowserContext* context)

extension_registry_observer_.Add(ExtensionRegistry::Get(profile_));

}

-SignedInDevicesManager::~SignedInDevicesManager() {

+SignedInDevicesManager::~SignedInDevicesManager() = default;

+void SignedInDevicesManager::Shutdown() {

if (profile_) {

EventRouter* router = EventRouter::Get(profile_);

if (router)