chrome/browser/extensions/extension_gcm_app_handler.h - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler.h

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_gcm_app_handler.h

diff --git a/chrome/browser/extensions/extension_gcm_app_handler.h b/chrome/browser/extensions/extension_gcm_app_handler.h

index ff89f8c0853655620b45d035100ba2cb72741915..33f03ed04d431b7ef10273e8cc32019c002aa08b 100644

--- a/chrome/browser/extensions/extension_gcm_app_handler.h

+++ b/chrome/browser/extensions/extension_gcm_app_handler.h

@@ -48,6 +48,7 @@ class ExtensionGCMAppHandler : public gcm::GCMAppHandler,

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<ExtensionGCMAppHandler>*

GetFactoryInstance();

+ void Shutdown() override;

// gcm::GCMAppHandler implementation.

void ShutdownHandler() override;