chrome/browser/extensions/api/input_ime/input_ime_api.h - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api.h

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/input_ime/input_ime_api.h

diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.h b/chrome/browser/extensions/api/input_ime/input_ime_api.h

index a4b849daa209e620032b2614c194169f0c4b6c4a..4dcdce5eff83274f40f76c7a13803e47f298f823 100644

--- a/chrome/browser/extensions/api/input_ime/input_ime_api.h

+++ b/chrome/browser/extensions/api/input_ime/input_ime_api.h

@@ -179,6 +179,7 @@ class InputImeAPI : public BrowserContextKeyedAPI,

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<InputImeAPI>* GetFactoryInstance();

+ void Shutdown() override;

// ExtensionRegistryObserver implementation.

void OnExtensionLoaded(content::BrowserContext* browser_context,