chrome/browser/engagement/site_engagement_service.h - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_service.h

diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h

index c97eb4abfa7bfa1aaf3887eb7886d66ced363286..5f2a0abc06156514bfe8b18c52a0eda13c0462b8 100644

--- a/chrome/browser/engagement/site_engagement_service.h

+++ b/chrome/browser/engagement/site_engagement_service.h

@@ -105,6 +105,9 @@ class SiteEngagementService : public KeyedService,

explicit SiteEngagementService(Profile* profile);

~SiteEngagementService() override;

+ // KeyedService support:

+ void Shutdown() override;

// Returns the engagement level of |url|.

blink::mojom::EngagementLevel GetEngagementLevel(const GURL& url) const;