chrome/browser/engagement/site_engagement_service.cc - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_service.cc

diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc

index edda88c4b38d468b73d20c7465cc203aec8c1342..f7d1bcf3da4d4dcb2cece6b75f5a80e7b81d18fa 100644

--- a/chrome/browser/engagement/site_engagement_service.cc

+++ b/chrome/browser/engagement/site_engagement_service.cc

@@ -122,7 +122,9 @@ SiteEngagementService::SiteEngagementService(Profile* profile)

}

-SiteEngagementService::~SiteEngagementService() {

+SiteEngagementService::~SiteEngagementService() = default;

+void SiteEngagementService::Shutdown() {

history::HistoryService* history = HistoryServiceFactory::GetForProfile(

profile_, ServiceAccessType::IMPLICIT_ACCESS);

if (history)