apps/app_load_service.cc - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/app_load_service.cc

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Add test fixes, more service shutdown fixes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/app_load_service.cc

diff --git a/apps/app_load_service.cc b/apps/app_load_service.cc

index c89a3692bf4ef15e29492daa8dfb93af37162753..ea706f43d8061e05163bb1f8d49e501be8bd6b4b 100644

--- a/apps/app_load_service.cc

+++ b/apps/app_load_service.cc

@@ -40,7 +40,9 @@ AppLoadService::AppLoadService(Profile* profile)

extensions::ExtensionRegistry::Get(profile_)->AddObserver(this);

}

-AppLoadService::~AppLoadService() {

+AppLoadService::~AppLoadService() = default;

+void AppLoadService::Shutdown() {

extensions::ExtensionRegistry::Get(profile_)->RemoveObserver(this);

}