Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2749643008: Revert of Use logdog butler subcommand to run tests. (Closed)

Created:
3 years, 9 months ago by BigBossZhiling
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use logdog butler subcommand to run tests. (patchset #42 id:820001 of https://codereview.chromium.org/2695963003/ ) Reason for revert: Increases time by a great deal. Original issue's description: > Use logdog butler subcommand to run tests. > > Previously we ran tests, without setting butler environment variables. > This will run into NotBootstrappedError when we try to upload test > results through logdog. > > In this cl, we use logdog butler subcommand to run tests, which will set > butler environment variables before hand. > > BUG=692287 > > Review-Url: https://codereview.chromium.org/2695963003 > Cr-Commit-Position: refs/heads/master@{#456976} > Committed: https://chromium.googlesource.com/chromium/src/+/de2df28c86b13227040aba5f9f5a1d1f869b81eb TBR=mikecase@chromium.org,dnj@chromium.org,jbudorick@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692287 Review-Url: https://codereview.chromium.org/2749643008 Cr-Commit-Position: refs/heads/master@{#457257} Committed: https://chromium.googlesource.com/chromium/src/+/d58d09ff7ef678920db1110ae5a0230f7d7cdb52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -285 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M build/android/test_runner.py View 5 chunks +1 line, -27 lines 0 comments Download
M build/android/test_wrapper/logdog_wrapper.py View 1 chunk +60 lines, -55 lines 0 comments Download
D build/android/test_wrapper/logdog_wrapper.pydeps View 1 chunk +0 lines, -11 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +1 line, -5 lines 0 comments Download
M testing/buildbot/chromium.android.json View 100 chunks +100 lines, -100 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 73 chunks +73 lines, -73 lines 0 comments Download
M tools/mb/mb.py View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
BigBossZhiling
Created Revert of Use logdog butler subcommand to run tests.
3 years, 9 months ago (2017-03-15 23:01:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749643008/1
3 years, 9 months ago (2017-03-15 23:02:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-15 23:02:59 UTC) #5
jbudorick
lgtm
3 years, 9 months ago (2017-03-15 23:07:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749643008/1
3 years, 9 months ago (2017-03-15 23:13:20 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 23:16:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d58d09ff7ef678920db1110ae5a0...

Powered by Google App Engine
This is Rietveld 408576698