Show Page Info button text in its tooltip

Show Page Info button text in its tooltip

In crrev.com/2407853002, Mac started showing the "verbose text" string
from the page info button in its tooltip. This improves accessibility
and enables display of the full text in cases where it might have been
truncated due to space constraints.

This CL brings the same change to Views for Windows/CrOS/Linux.

BUG=692683

[elawrence, 2017-03-14 16:48:20]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 16:48:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:34:47]

Dry run: This issue passed the CQ dry run.

[elawrence, 2017-03-14 18:32:35]

elawrence@chromium.org changed reviewers:
+ pkasting@chromium.org

[elawrence, 2017-03-14 18:32:35]

Please take a look?

[Peter Kasting, 2017-03-14 19:54:56]

https://codereview.chromium.org/2749643004/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_icon_view.cc (right):

https://codereview.chromium.org/2749643004/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_icon_view.cc:95: tip =
label()->text() + base::ASCIIToUTF16(". ") + tip;
This isn't OK for l10n -- if we're going to construct this string, we need a
localizable placeholder.

Honestly, I'm not thrilled with the way this reads ("Secure. View site
information" -- should be more like "This site is secure.  Click to view site
information" or something), and I'm a bit confused on the motive (e.g. the bug
mentions ellipsizing the chip, but it's not clear to me whether the omnibox ever
shrinks that small; if it does, should we only show this when ellipsized?).

Have you run this by the UX tech writer?  That's where I'd start with this
stuff; lay out the problems that you think need solving and get a localizable
string to add to the .grd file, then fill in its contents here.

[elawrence, 2017-03-14 21:32:08]

> Have you run this by the UX tech writer?  That's where I'd start with this
> stuff; lay out the problems that you think need solving and get a localizable
> string to add to the .grd file, then fill in its contents here.

Thanks, Peter. This bug was just to match Mac, but it sounds like that's not
okay for Views. I've asked hwi@ and rpop@ for their opinions from the UX side.

> information" or something), and I'm a bit confused on the motive (e.g. the bug
> mentions ellipsizing the chip, but it's not clear to me whether the omnibox
ever
> shrinks that small; if it does, should we only show this when ellipsized?).

Yes, it can definitely shrink that small. The easiest way would be to have a few
extension icons and a Chrome window of, say, 800px wide, then load
https://www.washingtonpost.com/. The EV chip has middle ellipsis.

> This isn't OK for l10n -- if we're going to construct this string, we need a
> localizable placeholder.

Yeah, I'm curious about what badness exists on Mac, since this landed there 5
months ago. For both l10n and readability, I think it makes more sense to just
join the strings with a \n so the text and the call to action appear on
different lines, but I'll let the UX folks weigh in.

[elawrence, 2017-03-14 22:06:14]

> Yes, it can definitely shrink that small. The easiest way would be to have a
few
> extension icons and a Chrome window of, say, 800px wide, then load
> https://www.washingtonpost.com/. The EV chip has middle ellipsis.

... though it turns out that the Label() already overrides the tooltip when an
ellipsis is present. So if you hover over the text today, you get the full text
and if you hover over the lock, you get "View site information". Wacky.

[elawrence, 2017-03-16 22:37:59]

Closing this CL.

After discussion with the UX team, the string "View site information" should
remain the tooltip and the Mac version should change to update its accessibility
info using a mechanism other than the tooltip. 

I've filed Issue 702406 to change the Mac implementation.