Show Page Info button text in its tooltip

chrome/browser/ui/views/location_bar/location_icon_view.cc

Index: chrome/browser/ui/views/location_bar/location_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc
index d388e2fa9b8f2eb769d3cfd2b20393d15a02ba67..b21d5a8dbc281ef88c38f34ce335508ebf0904ed 100644
--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc
@@ -88,8 +88,13 @@ void LocationIconView::OnGestureEvent(ui::GestureEvent* event) {
 
 bool LocationIconView::GetTooltipText(const gfx::Point& p,
                                       base::string16* tooltip) const {
-  if (show_tooltip_)
-    *tooltip = l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON);
+  if (show_tooltip_) {
+    base::string16 tip = l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON);
+    // Prepend the verbose text of the security chip, if any.
+    if (!label()->text().empty())
+      tip = label()->text() + base::ASCIIToUTF16(". ") + tip;

[Peter Kasting, 2017/03/14 19:54:56]

This isn't OK for l10n -- if we're going to construct this string, we need a
localizable placeholder.

Honestly, I'm not thrilled with the way this reads ("Secure. View site
information" -- should be more like "This site is secure.  Click to view site
information" or something), and I'm a bit confused on the motive (e.g. the bug
mentions ellipsizing the chip, but it's not clear to me whether the omnibox ever
shrinks that small; if it does, should we only show this when ellipsized?).

Have you run this by the UX tech writer?  That's where I'd start with this
stuff; lay out the problems that you think need solving and get a localizable
string to add to the .grd file, then fill in its contents here.

+    *tooltip = tip;
+  }
   return show_tooltip_;
 }