Show Page Info button text in its tooltip

chrome/browser/ui/views/location_bar/location_icon_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_icon_view.h"
 
 #include "chrome/browser/ui/view_ids.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 70 matching lines @@
 
 void LocationIconView::OnGestureEvent(ui::GestureEvent* event) {
   if (event->type() != ui::ET_GESTURE_TAP)
     return;
   OnClickOrTap(*event);
   event->SetHandled();
 }
 
 bool LocationIconView::GetTooltipText(const gfx::Point& p,
                                       base::string16* tooltip) const {
-  if (show_tooltip_)
-    *tooltip = l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON);
+  if (show_tooltip_) {
+    base::string16 tip = l10n_util::GetStringUTF16(IDS_TOOLTIP_LOCATION_ICON);
+    // Prepend the verbose text of the security chip, if any.
+    if (!label()->text().empty())
+      tip = label()->text() + base::ASCIIToUTF16(". ") + tip;

[Peter Kasting, 2017/03/14 19:54:56]

This isn't OK for l10n -- if we're going to construct this string, we need a
localizable placeholder.

Honestly, I'm not thrilled with the way this reads ("Secure. View site
information" -- should be more like "This site is secure.  Click to view site
information" or something), and I'm a bit confused on the motive (e.g. the bug
mentions ellipsizing the chip, but it's not clear to me whether the omnibox ever
shrinks that small; if it does, should we only show this when ellipsized?).

Have you run this by the UX tech writer?  That's where I'd start with this
stuff; lay out the problems that you think need solving and get a localizable
string to add to the .grd file, then fill in its contents here.

+    *tooltip = tip;
+  }
   return show_tooltip_;
 }
 
 SkColor LocationIconView::GetTextColor() const {
   return location_bar_->GetColor(LocationBarView::SECURITY_CHIP_TEXT);
 }
 
 bool LocationIconView::OnActivate(const ui::Event& event) {
   WebContents* contents = location_bar_->GetWebContents();
   if (!contents)
@@ skipping 49 matching lines @@
   return size;
 }
 
 void LocationIconView::OnClickOrTap(const ui::LocatedEvent& event) {
   // Do not show page info if the user has been editing the location bar or the
   // location bar is at the NTP.
   if (location_bar_->GetOmniboxView()->IsEditingOrEmpty())
     return;
   ProcessLocatedEvent(event);
 }