CrOS: Add a flag to allow easy selection of tablet mode.

CrOS: Add a flag to allow easy selection of tablet mode.

Adds a flag so users can force certain modes.
https://screenshot.googleplex.com/1Ny5PpP6MA6

TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*"
BUG=701135
Review-Url: https://codereview.chromium.org/2749633006
Cr-Commit-Position: refs/heads/master@{#457555}
Committed: https://chromium.googlesource.com/chromium/src/+/d583776463091d93eae768d76389c87dd39e5ca5

[sammiequon, 2017-03-14 00:27:47]

Description was changed from

==========
CrOS: Add a flag to allow easy selection of tablet mode.

Adds a flag so users can force certain modes.

TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*"
BUG=701135
==========

to

==========
CrOS: Add a flag to allow easy selection of tablet mode.

Adds a flag so users can force certain modes.
https://screenshot.googleplex.com/1Ny5PpP6MA6

TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*"
BUG=701135
==========

[sammiequon, 2017-03-14 00:27:48]

sammiequon@chromium.org changed reviewers:
+ zork@chromium.org

[sammiequon, 2017-03-14 00:33:03]

On 2017/03/14 00:27:48, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:zork@chromium.org

zork@ - Please take a look. Do these strings make sense? Thanks!

[Zachary Kuznia, 2017-03-14 00:54:24]

lgtm

[sammiequon, 2017-03-14 16:22:22]

sammiequon@chromium.org changed reviewers:
+ isherman@chromium.org

[sammiequon, 2017-03-14 16:23:12]

On 2017/03/14 00:54:24, Zachary Kuznia wrote:
> lgtm

Thanks!

isherman@ - Please take a look at histogram.xml. Thanks!

[Ilya Sherman, 2017-03-14 18:39:57]

histograms.xml lgtm

[srahim1, 2017-03-14 18:54:53]

srahim@google.com changed reviewers:
+ srahim@google.com

[srahim1, 2017-03-14 18:54:53]

Added a few clarifications for translation (chrome://flags are localized).

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5020: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_TOUCHVIEW" desc="Description of the TouchView
mode.">
Please add to the message description for translators: "In TouchView mode, the
keyboard can flip behind the screen so the Chromebook operates like a tablet
computer."

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5023: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_CLAMSHELL" desc="Description of the Clamshell
mode.">
Please add to the message description for translators: "In Clamshell mode, the
Chromebook operates like a standard laptop computer, keyboard on bottom, screen
on top, with a hinge like a clamshell."

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5026: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_AUTO" desc="Description of the default mode.">
To the message description, please add a clarification that "Description of the
default or 'automatic' mode." so that "Auto" doesn't get translated as
"automobile."

[Ilya Sherman, 2017-03-14 21:09:33]

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5020: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_TOUCHVIEW" desc="Description of the TouchView
mode.">
On 2017/03/14 18:54:53, srahim1 wrote:
> Please add to the message description for translators: "In TouchView mode, the
> keyboard can flip behind the screen so the Chromebook operates like a tablet
> computer."

Actually, for flags, it's preferred to add translateable="false" to the
<message>'s.  There is no need to translate flags -- they are intended to be
primarily developer-facing, rather than user-facing.

[sammiequon, 2017-03-15 15:33:04]

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5020: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_TOUCHVIEW" desc="Description of the TouchView
mode.">
On 2017/03/14 21:09:33, Ilya Sherman wrote:
> On 2017/03/14 18:54:53, srahim1 wrote:
> > Please add to the message description for translators: "In TouchView mode,
the
> > keyboard can flip behind the screen so the Chromebook operates like a tablet
> > computer."
> 
> Actually, for flags, it's preferred to add translateable="false" to the
> <message>'s.  There is no need to translate flags -- they are intended to be
> primarily developer-facing, rather than user-facing.

I added translateable="false", though I went ahead with srahim1@'s suggestions
to to make things a bit more clearer.

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5023: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_CLAMSHELL" desc="Description of the Clamshell
mode.">
On 2017/03/14 18:54:53, srahim1 wrote:
> Please add to the message description for translators: "In Clamshell mode, the
> Chromebook operates like a standard laptop computer, keyboard on bottom,
screen
> on top, with a hinge like a clamshell."

Done.

https://codereview.chromium.org/2749633006/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:5026: +      <message
name="IDS_FLAGS_FORCE_TABLET_MODE_AUTO" desc="Description of the default mode.">
On 2017/03/14 18:54:53, srahim1 wrote:
> To the message description, please add a clarification that "Description of
the
> default or 'automatic' mode." so that "Auto" doesn't get translated as
> "automobile." 

Done.

[sammiequon, 2017-03-16 01:44:28]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2017-03-16 01:44:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, zork@chromium.org
Link to the patchset: https://codereview.chromium.org/2749633006/#ps20001
(title: "Patch set 1 fixes.")

[commit-bot: I haz the power, 2017-03-16 01:44:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:47:43]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sammiequon, 2017-03-16 19:00:48]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 19:01:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 19:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 19:06:02]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sammiequon, 2017-03-16 19:22:12]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 19:22:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 20:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:37:46]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-03-16 21:05:14]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2017-03-16 21:05:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, zork@chromium.org
Link to the patchset: https://codereview.chromium.org/2749633006/#ps60001
(title: "Reparent to master.")

[commit-bot: I haz the power, 2017-03-16 21:05:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:15:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489698314478370,
"parent_rev": "316bf80fdc4c14a6738b9ead44718a30f8cf4f4d", "commit_rev":
"d583776463091d93eae768d76389c87dd39e5ca5"}

[commit-bot: I haz the power, 2017-03-16 21:15:45]

Description was changed from

==========
CrOS: Add a flag to allow easy selection of tablet mode.

Adds a flag so users can force certain modes.
https://screenshot.googleplex.com/1Ny5PpP6MA6

TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*"
BUG=701135
==========

to

==========
CrOS: Add a flag to allow easy selection of tablet mode.

Adds a flag so users can force certain modes.
https://screenshot.googleplex.com/1Ny5PpP6MA6

TEST=unit_tests --gtest_filter="AboutFlagsHistogramTest.*"
BUG=701135

Review-Url: https://codereview.chromium.org/2749633006
Cr-Commit-Position: refs/heads/master@{#457555}
Committed:
https://chromium.googlesource.com/chromium/src/+/d583776463091d93eae768d76389...
==========

[commit-bot: I haz the power, 2017-03-16 21:15:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d583776463091d93eae768d76389...