Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/about_flags.cc

Issue 2749633006: CrOS: Add a flag to allow easy selection of tablet mode. (Closed)
Patch Set: Reparent to master. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e78f890100068c438e83c7f07f25ffaa44fb4aad..36e5720de845d7390b6b15b09001edf93fd4301d 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -505,6 +505,18 @@ const FeatureEntry::Choice kNtpSwitchToExistingTabChoices[] = {
};
#endif // OS_ANDROID
+#if defined(OS_CHROMEOS)
+const FeatureEntry::Choice kForceTabletModeChoices[] = {
+ {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
+ {IDS_FLAGS_FORCE_TABLET_MODE_TOUCHVIEW, switches::kForceTabletMode,
+ switches::kForceTabletModeTouchView},
+ {IDS_FLAGS_FORCE_TABLET_MODE_CLAMSHELL, switches::kForceTabletMode,
+ switches::kForceTabletModeClamshell},
+ {IDS_FLAGS_FORCE_TABLET_MODE_AUTO, switches::kForceTabletMode,
+ switches::kForceTabletModeAuto},
+};
+#endif // OS_CHROMEOS
+
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam
kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
@@ -2374,6 +2386,12 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_MOJO_LOADING_DESCRIPTION, kOsAll,
FEATURE_VALUE_TYPE(features::kLoadingWithMojo)},
+#if defined(OS_CHROMEOS)
+ {"force-tablet-mode", IDS_FLAGS_FORCE_TABLET_MODE_NAME,
+ IDS_FLAGS_FORCE_TABLET_MODE_DESCRIPTION, kOsCrOS,
+ MULTI_VALUE_TYPE(kForceTabletModeChoices)},
+#endif // OS_CHROMEOS
+
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698