Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2749583003: predictors: Don't record URLs with a port. (Closed)

Created:
3 years, 9 months ago by Benoit L
Modified:
3 years, 9 months ago
Reviewers:
droger, alexilin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Don't record URLs with a port. BUG=631966 Review-Url: https://codereview.chromium.org/2749583003 Cr-Commit-Position: refs/heads/master@{#457406} Committed: https://chromium.googlesource.com/chromium/src/+/0b6891ca2968c288af67584dd2ce758ef12fd699

Patch Set 1 #

Patch Set 2 : Add exception for browser tests. #

Patch Set 3 : Add a comment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 3 chunks +14 lines, -2 lines 1 comment Download
M chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc View 1 2 1 chunk +6 lines, -0 lines 1 comment Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 4 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Benoit L
3 years, 9 months ago (2017-03-14 16:06:26 UTC) #2
Benoit L
Now with 100% less failing tests. PTAL, thanks.
3 years, 9 months ago (2017-03-15 16:06:59 UTC) #11
alexilin
https://codereview.chromium.org/2749583003/diff/40001/chrome/browser/predictors/resource_prefetch_predictor.cc File chrome/browser/predictors/resource_prefetch_predictor.cc (right): https://codereview.chromium.org/2749583003/diff/40001/chrome/browser/predictors/resource_prefetch_predictor.cc#newcode55 chrome/browser/predictors/resource_prefetch_predictor.cc:55: bool g_allow_port_in_urls = false; Why global flag and static ...
3 years, 9 months ago (2017-03-15 17:56:26 UTC) #12
alexilin
Discussed offline: static methods (IsHandled*) need this flag. We don't want to make them class ...
3 years, 9 months ago (2017-03-15 18:02:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749583003/40001
3 years, 9 months ago (2017-03-16 09:14:18 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-16 09:14:20 UTC) #17
Benoit L
3 years, 9 months ago (2017-03-16 09:17:36 UTC) #19
droger
lgtm, mostly rubberstamping https://codereview.chromium.org/2749583003/diff/40001/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc File chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc (right): https://codereview.chromium.org/2749583003/diff/40001/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc#newcode340 chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc:340: ResourcePrefetchPredictor::SetAllowPortInUrlsForTesting(false); Nit, optional: Could we use ...
3 years, 9 months ago (2017-03-16 12:02:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749583003/40001
3 years, 9 months ago (2017-03-16 12:20:44 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 12:26:44 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0b6891ca2968c288af67584dd2ce...

Powered by Google App Engine
This is Rietveld 408576698