Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

Issue 2749583003: predictors: Don't record URLs with a port. (Closed)
Patch Set: Add a comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
index 1e4e487acedb5e3db494396d7f3637c8a3f096e1..a2b1c53aedaba9a868e48ebf9275fb44589f1a94 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
@@ -1250,6 +1250,12 @@ TEST_F(ResourcePrefetchPredictorTest, ShouldRecordRequestMainFrame) {
content::RESOURCE_TYPE_IMAGE, true);
EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordRequest(
file_request.get(), content::RESOURCE_TYPE_MAIN_FRAME));
+
+ std::unique_ptr<net::URLRequest> https_request_with_port =
+ CreateURLRequest(GURL("https://www.google.com:666"), net::MEDIUM,
+ content::RESOURCE_TYPE_IMAGE, true);
+ EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordRequest(
+ https_request_with_port.get(), content::RESOURCE_TYPE_MAIN_FRAME));
}
TEST_F(ResourcePrefetchPredictorTest, ShouldRecordRequestSubResource) {
@@ -1270,6 +1276,12 @@ TEST_F(ResourcePrefetchPredictorTest, ShouldRecordRequestSubResource) {
content::RESOURCE_TYPE_IMAGE, false);
EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordRequest(
file_request.get(), content::RESOURCE_TYPE_IMAGE));
+
+ std::unique_ptr<net::URLRequest> https_request_with_port =
+ CreateURLRequest(GURL("https://www.google.com:666/cat.png"), net::MEDIUM,
+ content::RESOURCE_TYPE_IMAGE, false);
+ EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordRequest(
+ https_request_with_port.get(), content::RESOURCE_TYPE_IMAGE));
}
TEST_F(ResourcePrefetchPredictorTest, ShouldRecordResponseMainFrame) {
@@ -1294,6 +1306,12 @@ TEST_F(ResourcePrefetchPredictorTest, ShouldRecordResponseMainFrame) {
content::RESOURCE_TYPE_MAIN_FRAME, true);
EXPECT_FALSE(
ResourcePrefetchPredictor::ShouldRecordResponse(file_request.get()));
+
+ std::unique_ptr<net::URLRequest> https_request_with_port =
+ CreateURLRequest(GURL("https://www.google.com:666"), net::MEDIUM,
+ content::RESOURCE_TYPE_MAIN_FRAME, true);
+ EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordResponse(
+ https_request_with_port.get()));
}
TEST_F(ResourcePrefetchPredictorTest, ShouldRecordResponseSubresource) {
@@ -1316,6 +1334,12 @@ TEST_F(ResourcePrefetchPredictorTest, ShouldRecordResponseSubresource) {
EXPECT_TRUE(ResourcePrefetchPredictor::ShouldRecordResponse(
https_image_request.get()));
+ std::unique_ptr<net::URLRequest> https_image_request_with_port =
+ CreateURLRequest(GURL("https://www.google.com:666/cat.png"), net::MEDIUM,
+ content::RESOURCE_TYPE_IMAGE, true);
+ EXPECT_FALSE(ResourcePrefetchPredictor::ShouldRecordResponse(
+ https_image_request_with_port.get()));
+
std::unique_ptr<net::URLRequest> file_image_request =
CreateURLRequest(GURL("file://www.google.com/cat.png"), net::MEDIUM,
content::RESOURCE_TYPE_IMAGE, true);

Powered by Google App Engine
This is Rietveld 408576698